[PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-01-28 Thread Joerg Roedel
This patch changes the implementation of of kvm_iommu_map_pages to map the pages with the host page size into the io virtual address space. Signed-off-by: Joerg Roedel --- virt/kvm/iommu.c | 106 ++--- 1 files changed, 84 insertions(+), 22 deletio

Re: [PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-01-28 Thread Marcelo Tosatti
On Thu, Jan 28, 2010 at 12:37:57PM +0100, Joerg Roedel wrote: > This patch changes the implementation of of > kvm_iommu_map_pages to map the pages with the host page size > into the io virtual address space. > > Signed-off-by: Joerg Roedel > --- > virt/kvm/iommu.c | 106

Re: [PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-01-29 Thread Joerg Roedel
On Thu, Jan 28, 2010 at 08:24:55PM -0200, Marcelo Tosatti wrote: > On Thu, Jan 28, 2010 at 12:37:57PM +0100, Joerg Roedel wrote: > > +static pfn_t kvm_pin_pages(struct kvm *kvm, struct kvm_memory_slot *slot, > > + gfn_t gfn, unsigned long size) > > +{ > > + gfn_t end_gfn; > >

Re: [PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-02-01 Thread Joerg Roedel
hat too. Here is the updated patch (also updated in the iommu/largepage branch of my tree). Does it look ok? >From fa921fe46a92dadf7f66391b519cb9ca92e2ee83 Mon Sep 17 00:00:00 2001 From: Joerg Roedel Date: Mon, 11 Jan 2010 16:38:18 +0100 Subject: [PATCH 06/11] kvm: Change kvm_iommu_map_pages t

Re: [PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-02-01 Thread Marcelo Tosatti
On Mon, Feb 01, 2010 at 03:18:04PM +0100, Joerg Roedel wrote: > On Fri, Jan 29, 2010 at 10:32:33AM +0100, Joerg Roedel wrote: > > On Thu, Jan 28, 2010 at 08:24:55PM -0200, Marcelo Tosatti wrote: > > > On Thu, Jan 28, 2010 at 12:37:57PM +0100, Joerg Roedel wrote: > > > > +static pfn_t kvm_pin_pages(

Re: [PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-02-05 Thread Joerg Roedel
Hi Marcelo, Avi, On Mon, Feb 01, 2010 at 05:30:17PM -0200, Marcelo Tosatti wrote: > On Mon, Feb 01, 2010 at 03:18:04PM +0100, Joerg Roedel wrote: > > On Fri, Jan 29, 2010 at 10:32:33AM +0100, Joerg Roedel wrote: > > > On Thu, Jan 28, 2010 at 08:24:55PM -0200, Marcelo Tosatti wrote: > > > > On Thu,

Re: [PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-02-07 Thread Avi Kivity
On 01/29/2010 12:24 AM, Marcelo Tosatti wrote: On Thu, Jan 28, 2010 at 12:37:57PM +0100, Joerg Roedel wrote: This patch changes the implementation of of kvm_iommu_map_pages to map the pages with the host page size into the io virtual address space. Signed-off-by: Joerg Roedel --- virt/kvm

Re: [PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-02-07 Thread Avi Kivity
On 02/05/2010 01:01 PM, Joerg Roedel wrote: Yes, addresses the concern. Are there any further objections against this patchset? If not it would be cool if you could give me some acks for the kvm specific parts of this patchset. There are two ways we can get the kvm bits in: - you

Re: [PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-02-07 Thread Joerg Roedel
On Sun, Feb 07, 2010 at 02:22:35PM +0200, Avi Kivity wrote: > On 02/05/2010 01:01 PM, Joerg Roedel wrote: >> >>> Yes, addresses the concern. >>> >> Are there any further objections against this patchset? If not it would >> be cool if you could give me some acks for the kvm specific parts of >

Re: [PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-02-07 Thread Marcelo Tosatti
On Sun, Feb 07, 2010 at 02:18:19PM +0200, Avi Kivity wrote: > On 01/29/2010 12:24 AM, Marcelo Tosatti wrote: > >On Thu, Jan 28, 2010 at 12:37:57PM +0100, Joerg Roedel wrote: > >>This patch changes the implementation of of > >>kvm_iommu_map_pages to map the pages with the host page size > >>into the

Re: [PATCH 06/11] kvm: Change kvm_iommu_map_pages to map large pages

2010-02-08 Thread Avi Kivity
On 02/07/2010 08:41 PM, Marcelo Tosatti wrote: How could it return a bad_page? The whole thing is called for a valid slot. Userspace can pass a valid slot with a read-only vma, for example. Oh yes, or without a vma at all. -- error compiling committee.c: too many arguments to fun