Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/08/2011 08:43 PM, Peter Maydell wrote: On 8 August 2011 18:06, Avi Kivitya...@redhat.com wrote: Somewhat clumsy since it needs a variable sized region. @@ -119,7 +120,7 @@ void omap_sdrc_reset(struct omap_sdrc_s *s); struct omap_gpmc_s; struct omap_gpmc_s

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Peter Maydell
On 9 August 2011 07:34, Avi Kivity a...@redhat.com wrote: Also, my patchset focuses on mechanical transformations.  It is already risky enough in terms of regressions, I'm not going to rewrite/improve all of qemu; if you want those callbacks removed, you will have to remove them yourself.

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 10:37 AM, Peter Maydell wrote: On 9 August 2011 07:34, Avi Kivitya...@redhat.com wrote: Also, my patchset focuses on mechanical transformations. It is already risky enough in terms of regressions, I'm not going to rewrite/improve all of qemu; if you want those callbacks

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Peter Maydell
On 9 August 2011 08:41, Avi Kivity a...@redhat.com wrote: On 08/09/2011 10:37 AM, Peter Maydell wrote: On 9 August 2011 07:34, Avi Kivitya...@redhat.com  wrote:  Also, my patchset focuses on mechanical transformations.  It is already  risky enough in terms of regressions, I'm not going to

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 11:07 AM, Peter Maydell wrote: On 9 August 2011 08:41, Avi Kivitya...@redhat.com wrote: On 08/09/2011 10:37 AM, Peter Maydell wrote: On 9 August 2011 07:34, Avi Kivitya...@redhat.comwrote: Also, my patchset focuses on mechanical transformations. It is already

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-09 Thread Avi Kivity
On 08/09/2011 11:44 AM, Avi Kivity wrote: ...isn't this just throwing away the warnings on bad-width accesses? It is; will fix. Reading the original code, it seems broken: uint32_t omap_badwidth_read32(void *opaque, target_phys_addr_t addr) { uint32_t ret; OMAP_32B_REG(addr);

[PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-08 Thread Avi Kivity
Somewhat clumsy since it needs a variable sized region. Signed-off-by: Avi Kivity a...@redhat.com --- hw/omap.h |3 ++- hw/omap_gpmc.c | 53 + hw/tusb6010.c | 30 +- hw/tusb6010.h |7 +-- 4

Re: [Qemu-devel] [PATCH 09/24] omap_gpmc/nseries/tusb6010: convert to memory API

2011-08-08 Thread Peter Maydell
On 8 August 2011 18:06, Avi Kivity a...@redhat.com wrote: Somewhat clumsy since it needs a variable sized region. @@ -119,7 +120,7 @@ void omap_sdrc_reset(struct omap_sdrc_s *s);  struct omap_gpmc_s;  struct omap_gpmc_s *omap_gpmc_init(target_phys_addr_t base, qemu_irq irq);  void