Re: [PATCH 1/1] kvmclock: fix guest stop notification

2012-10-08 Thread Amit Shah
On (Sun) 30 Sep 2012 [21:50:07], Amos Kong wrote: > - Original Message - > > On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: > > > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > > > > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest > > > > stop

Re: [PATCH 1/1] kvmclock: fix guest stop notification

2012-10-08 Thread Amit Shah
On (Sun) 30 Sep 2012 [20:05:16], Marcelo Tosatti wrote: > On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: > > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > > > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop > > > notification, but it did it in a

Re: [PATCH 1/1] kvmclock: fix guest stop notification

2012-10-03 Thread Marcelo Tosatti
On Sun, Sep 30, 2012 at 09:50:07PM -0400, Amos Kong wrote: > - Original Message - > > On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: > > > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > > > > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest > >

Re: [PATCH 1/1] kvmclock: fix guest stop notification

2012-09-30 Thread Amos Kong
- Original Message - > On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: > > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > > > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest > > > stop In commitlog of f349c12c0434e29c79ecde89029320c4002f7253:

Re: [PATCH 1/1] kvmclock: fix guest stop notification

2012-09-30 Thread Marcelo Tosatti
On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop > > notification, but it did it in a way that the stop notification would > > never reach the kernel

Re: [PATCH 1/1] kvmclock: fix guest stop notification

2012-09-20 Thread Marcelo Tosatti
Amit, should please use "uq/master" in the subject to help the person who is merging patches. On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop > notification, but it did it in a way that the stop notification would >

Re: [PATCH 1/1] kvmclock: fix guest stop notification

2012-09-20 Thread Marcelo Tosatti
On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop > notification, but it did it in a way that the stop notification would > never reach the kernel. The kvm_vm_state_changed() function gets a > value of 0 for the 'runni

[PATCH 1/1] kvmclock: fix guest stop notification

2012-09-20 Thread Amit Shah
Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop notification, but it did it in a way that the stop notification would never reach the kernel. The kvm_vm_state_changed() function gets a value of 0 for the 'running' parameter when the VM is stopped, making all the code added pre