Re: [PATCH 1/2] don't start cpu main loop while there is still init work to do.

2009-05-04 Thread Avi Kivity
Glauber Costa wrote: As soon as we call kvm_init_vcpu(), we start the vcpu thread. However, there is still things that has to be done, as soon as the new CPUState is created. Examples include initializing the apic, halting the cpu, etc. Without this patch, it is possible that the cpu may want

Re: [PATCH 1/2] don't start cpu main loop while there is still init work to do.

2009-05-04 Thread Glauber Costa
On Mon, May 04, 2009 at 11:30:58AM +0300, Avi Kivity wrote: Glauber Costa wrote: As soon as we call kvm_init_vcpu(), we start the vcpu thread. However, there is still things that has to be done, as soon as the new CPUState is created. Examples include initializing the apic, halting the cpu,

Re: [PATCH 1/2] don't start cpu main loop while there is still init work to do.

2009-05-04 Thread Glauber Costa
On Mon, May 04, 2009 at 05:33:26PM +0300, Avi Kivity wrote: Glauber Costa wrote: I'd like to avoid vcpu ioctls from more than one thread, in case we ever move to a syscall implementation. Although I don't see exactly what's your point in here. We're just adding a serialization points

Re: [PATCH 1/2] don't start cpu main loop while there is still init work to do.

2009-05-04 Thread Avi Kivity
Glauber Costa wrote: On Mon, May 04, 2009 at 05:33:26PM +0300, Avi Kivity wrote: Glauber Costa wrote: I'd like to avoid vcpu ioctls from more than one thread, in case we ever move to a syscall implementation. Although I don't see exactly what's your point in here. We're

Re: [PATCH 1/2] don't start cpu main loop while there is still init work to do.

2009-05-04 Thread Avi Kivity
Glauber Costa wrote: I'd like to avoid vcpu ioctls from more than one thread, in case we ever move to a syscall implementation. Although I don't see exactly what's your point in here. We're just adding a serialization points through pthreads function, not doing any ioctl from the

[PATCH 1/2] don't start cpu main loop while there is still init work to do.

2009-04-29 Thread Glauber Costa
As soon as we call kvm_init_vcpu(), we start the vcpu thread. However, there is still things that has to be done, as soon as the new CPUState is created. Examples include initializing the apic, halting the cpu, etc. Without this patch, it is possible that the cpu may want to start using those