Re: [Qemu-devel] Re: [PATCH 1/3] Only call aio flush handler if set

2008-09-23 Thread Anthony Liguori
Ryan Harper wrote: * Anthony Liguori <[EMAIL PROTECTED]> [2008-09-23 09:36]: I disagree that anything is worse off by not SEGV'ing, In any case, what do you want here? Read or Write must be set along with flush or we error in fd registration? Yes. Regards, Anthony Liguori -- To uns

Re: [Qemu-devel] Re: [PATCH 1/3] Only call aio flush handler if set

2008-09-23 Thread Ryan Harper
* Anthony Liguori <[EMAIL PROTECTED]> [2008-09-23 09:36]: > Ryan Harper wrote: > >* Anthony Liguori <[EMAIL PROTECTED]> [2008-09-22 21:49]: > > > >>Ryan Harper wrote: > >> > >>>If the aio handler doesn't register an io_flush handler, we'd SEGV; fix > >>>that by > >>>only calling the flush ha

Re: [Qemu-devel] Re: [PATCH 1/3] Only call aio flush handler if set

2008-09-23 Thread Anthony Liguori
Ryan Harper wrote: * Anthony Liguori <[EMAIL PROTECTED]> [2008-09-22 21:49]: Ryan Harper wrote: If the aio handler doesn't register an io_flush handler, we'd SEGV; fix that by only calling the flush handler if set. BTW, aio handlers *should* register an io_flush routine. Signed-off-

Re: [Qemu-devel] Re: [PATCH 1/3] Only call aio flush handler if set

2008-09-23 Thread Ryan Harper
* Anthony Liguori <[EMAIL PROTECTED]> [2008-09-22 21:49]: > Ryan Harper wrote: > >If the aio handler doesn't register an io_flush handler, we'd SEGV; fix > >that by > >only calling the flush handler if set. BTW, aio handlers *should* > >register an > >io_flush routine. > > > >Signed-off-by: Ryan

Re: [PATCH 1/3] Only call aio flush handler if set

2008-09-22 Thread Anthony Liguori
Ryan Harper wrote: If the aio handler doesn't register an io_flush handler, we'd SEGV; fix that by only calling the flush handler if set. BTW, aio handlers *should* register an io_flush routine. Signed-off-by: Ryan Harper <[EMAIL PROTECTED]> diff --git a/aio.c b/aio.c index 687e4be..2bb3ed4 10

[PATCH 1/3] Only call aio flush handler if set

2008-09-22 Thread Ryan Harper
If the aio handler doesn't register an io_flush handler, we'd SEGV; fix that by only calling the flush handler if set. BTW, aio handlers *should* register an io_flush routine. Signed-off-by: Ryan Harper <[EMAIL PROTECTED]> diff --git a/aio.c b/aio.c index 687e4be..2bb3ed4 100644 --- a/aio.c +++