Re: [PATCH 1/4] KVM: MMU: Split the main body of rmap_write_protect() off from others

2012-03-12 Thread Takuya Yoshikawa
Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp wrote: -int kvm_mmu_rmap_write_protect(struct kvm *kvm, u64 gfn, -struct kvm_memory_slot *slot) +static int __rmap_write_protect(struct kvm *kvm, unsigned long *rmapp, int level) { - unsigned long *rmapp; -

Re: [PATCH 1/4] KVM: MMU: Split the main body of rmap_write_protect() off from others

2012-03-12 Thread Takuya Yoshikawa
Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp wrote: Something may change here: when level PT_PAGE_TABLE_LEVEL, this loop does not handle lower level mappings after dropping large-ptes. This may be incorrect. On second thoughts, this seems to be no problem. I was just confused. Thanks,

[PATCH 1/4] KVM: MMU: Split the main body of rmap_write_protect() off from others

2012-03-01 Thread Takuya Yoshikawa
We will use this in the following patch to implement another function which needs to write protect pages using the rmap information. Note that there is a small change in debug printing for large pages: we do not differentiate them from others to avoid duplicating code. Signed-off-by: Takuya

[PATCH 1/4] KVM: MMU: Split the main body of rmap_write_protect() off from others

2012-02-23 Thread Takuya Yoshikawa
We will use this in the following patch to implement another function which needs to write protect pages using the rmap information. Note that there is a small change in debug printing for large pages: we do not differentiate them from others to avoid duplicating code. Signed-off-by: Takuya