Re: [PATCH 1/5] KVM: MMU: Push clean gpte write protection out of gpte_access()

2012-09-13 Thread Xiao Guangrong
On 09/12/2012 10:29 PM, Avi Kivity wrote: gpte_access() computes the access permissions of a guest pte and also write-protects clean gptes. This is wrong when we are servicing a write fault (since we'll be setting the dirty bit momentarily) but correct when instantiating a speculative spte,

[PATCH 1/5] KVM: MMU: Push clean gpte write protection out of gpte_access()

2012-09-12 Thread Avi Kivity
gpte_access() computes the access permissions of a guest pte and also write-protects clean gptes. This is wrong when we are servicing a write fault (since we'll be setting the dirty bit momentarily) but correct when instantiating a speculative spte, or when servicing a read fault (since we'll

[PATCH 1/5] KVM: MMU: Push clean gpte write protection out of gpte_access()

2012-09-12 Thread Avi Kivity
gpte_access() computes the access permissions of a guest pte and also write-protects clean gptes. This is wrong when we are servicing a write fault (since we'll be setting the dirty bit momentarily) but correct when instantiating a speculative spte, or when servicing a read fault (since we'll