Re: [PATCH 1/5] block: add bio_map_sg

2011-10-06 Thread Christoph Hellwig
On Thu, Oct 06, 2011 at 12:51:39AM +0200, Boaz Harrosh wrote: > I have some questions. > > - Could we later use this bio_map_sg() to implement blk_rq_map_sg() and > remove some duplicated code? I didn't even think about that, but it actually looks very possible to factor the "meat" in the for e

Re: [PATCH 1/5] block: add bio_map_sg

2011-10-05 Thread Boaz Harrosh
On 10/05/2011 09:54 PM, Christoph Hellwig wrote: > Add a helper to map a bio to a scatterlist, modelled after blk_rq_map_sg. > This helper is useful for any driver that wants to create a scatterlist > from its ->make_request method. > > Signed-off-by: Christoph Hellwig > I have some questions.

[PATCH 1/5] block: add bio_map_sg

2011-10-05 Thread Christoph Hellwig
Add a helper to map a bio to a scatterlist, modelled after blk_rq_map_sg. This helper is useful for any driver that wants to create a scatterlist from its ->make_request method. Signed-off-by: Christoph Hellwig Index: linux-2.6/block/blk-merge.c ==