Re: [PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-16 Thread Michael S. Tsirkin
On Fri, Nov 12, 2010 at 08:49:20AM -0700, Alex Williamson wrote: > > > > > @@ -1207,18 +1208,14 @@ void pci_default_cap_write_config(PCIDevice > > > > > *pci_dev, > > > > > > > > > > void pci_default_write_config(PCIDevice *d, uint32_t addr, uint32_t > > > > > val, int l) > > > > > { > > > >

Re: [PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-12 Thread Alex Williamson
On Fri, 2010-11-12 at 10:48 +0200, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2010 at 11:03:19PM -0700, Alex Williamson wrote: > > On Fri, 2010-11-12 at 07:22 +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 11, 2010 at 07:55:01PM -0700, Alex Williamson wrote: > > > > Make use of wmask, just lik

Re: [PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-12 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 11:03:19PM -0700, Alex Williamson wrote: > On Fri, 2010-11-12 at 07:22 +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 11, 2010 at 07:55:01PM -0700, Alex Williamson wrote: > > > Make use of wmask, just like the rest of config space. > > > > > > Signed-off-by: Alex Williams

Re: [PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-11 Thread Alex Williamson
On Fri, 2010-11-12 at 07:22 +0200, Michael S. Tsirkin wrote: > On Thu, Nov 11, 2010 at 07:55:01PM -0700, Alex Williamson wrote: > > Make use of wmask, just like the rest of config space. > > > > Signed-off-by: Alex Williamson > > --- > > > > hw/pci.c | 19 --- > > 1 files chan

Re: [PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-11 Thread Michael S. Tsirkin
On Thu, Nov 11, 2010 at 07:55:01PM -0700, Alex Williamson wrote: > Make use of wmask, just like the rest of config space. > > Signed-off-by: Alex Williamson > --- > > hw/pci.c | 19 --- > 1 files changed, 8 insertions(+), 11 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c >

[PATCH 1/8] pci: pci_default_cap_write_config ignores wmask

2010-11-11 Thread Alex Williamson
Make use of wmask, just like the rest of config space. Signed-off-by: Alex Williamson --- hw/pci.c | 19 --- 1 files changed, 8 insertions(+), 11 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 92aaa85..12c47ac 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1175,13 +1175,14 @@