Re: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM

2012-09-27 Thread Catalin Marinas
On Thu, Sep 27, 2012 at 06:15:05PM +0100, Christoffer Dall wrote: > On Thu, Sep 27, 2012 at 8:39 AM, Catalin Marinas > wrote: > > On 25 September 2012 13:38, Christoffer Dall > > wrote: > + > + /* > + * If this is a write fault (think COW) we need to make sure the > +

Re: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM

2012-09-27 Thread Christoffer Dall
On Thu, Sep 27, 2012 at 8:39 AM, Catalin Marinas wrote: > On 25 September 2012 13:38, Christoffer Dall > wrote: + + /* + * If this is a write fault (think COW) we need to make sure the + * existing page, which other CPUs might still read, doesn't go away >>>

Re: [kvmarm] [PATCH 13/15] KVM: ARM: Handle guest faults in KVM

2012-09-27 Thread Marc Zyngier
gt; Cc: kvm@vger.kernel.org; linux-arm-ker...@lists.infradead.org; >> kvm...@lists.cs.columbia.edu; ?? >> Subject: Re: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM >> >>>> + >>>> + /* >>>> + * If this is a write fault (think COW) we need to ma

Re: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM

2012-09-27 Thread Catalin Marinas
On 25 September 2012 13:38, Christoffer Dall wrote: >>> + >>> + /* >>> + * If this is a write fault (think COW) we need to make sure the >>> + * existing page, which other CPUs might still read, doesn't go >>> away >>> + * from under us, by calling gfn_to_pfn_prot(write_fault=tr

Re: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM

2012-09-26 Thread Christoffer Dall
gt; Cc: kvm@vger.kernel.org; linux-arm-ker...@lists.infradead.org; >> kvm...@lists.cs.columbia.edu; 김창환 >> Subject: Re: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM >> >> >> + >> >> + /* >> >> + * If this is a write fault (thi

RE: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM

2012-09-26 Thread Min-gyu Kim
.cs.columbia.edu; 김창환 > Subject: Re: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM > > >> + > >> + /* > >> + * If this is a write fault (think COW) we need to make sure the > >> + * existing page, which other CPUs might still rea

Re: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM

2012-09-25 Thread Christoffer Dall
>> + >> + /* >> + * If this is a write fault (think COW) we need to make sure the >> + * existing page, which other CPUs might still read, doesn't go >> away >> + * from under us, by calling gfn_to_pfn_prot(write_fault=true). >> + * Therefore, we call gfn_to_pfn_prot(write_f

RE: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM

2012-09-25 Thread Min-gyu Kim
Subject: [PATCH 13/15] KVM: ARM: Handle guest faults in KVM > > From: Christoffer Dall > > Handles the guest faults in KVM by mapping in corresponding user pages in > the 2nd stage page tables. > > We invalidate the instruction cache by MVA whenever we map a page to the > gu

[PATCH 13/15] KVM: ARM: Handle guest faults in KVM

2012-09-15 Thread Christoffer Dall
From: Christoffer Dall Handles the guest faults in KVM by mapping in corresponding user pages in the 2nd stage page tables. We invalidate the instruction cache by MVA whenever we map a page to the guest (no, we cannot only do it when we have an iabt because the guest may happily read/write a pag