Re: [PATCH 16/28] kvm tools: Allow load_flat_binary() to load an initrd alongside

2011-12-06 Thread Cyrill Gorcunov
On Wed, Dec 07, 2011 at 11:42:27AM +1100, Matt Evans wrote: > Hi Cyrill, > > On 06/12/11 23:04, Cyrill Gorcunov wrote: > > On Tue, Dec 06, 2011 at 12:29:48PM +0200, Pekka Enberg wrote: > > ... > >> > >> Otherwise looks OK to me. Cyrill? > >> > > > > It might be not seen from patch (or my local kv

Re: [PATCH 16/28] kvm tools: Allow load_flat_binary() to load an initrd alongside

2011-12-06 Thread Matt Evans
Hi Cyrill, On 06/12/11 23:04, Cyrill Gorcunov wrote: > On Tue, Dec 06, 2011 at 12:29:48PM +0200, Pekka Enberg wrote: > ... >> >> Otherwise looks OK to me. Cyrill? >> > > It might be not seen from patch (or my local kvm repo > is not yet updated well) but I somehow miss who will be > reading initr

Re: [PATCH 16/28] kvm tools: Allow load_flat_binary() to load an initrd alongside

2011-12-06 Thread Cyrill Gorcunov
On Tue, Dec 06, 2011 at 12:29:48PM +0200, Pekka Enberg wrote: ... > > Otherwise looks OK to me. Cyrill? > It might be not seen from patch (or my local kvm repo is not yet updated well) but I somehow miss who will be reading initrd in case of loading flat image? If noone, then what's the point to

Re: [PATCH 16/28] kvm tools: Allow load_flat_binary() to load an initrd alongside

2011-12-06 Thread Pekka Enberg
On Tue, Dec 6, 2011 at 5:41 AM, Matt Evans wrote: > This patch passes the initrd fd and commandline to load_flat_binary(), which > may > be used to load both the kernel & an initrd (stashing or inserting the > commandline as appropriate) in the same way that load_bzimage() does.  This is > especi

[PATCH 16/28] kvm tools: Allow load_flat_binary() to load an initrd alongside

2011-12-05 Thread Matt Evans
This patch passes the initrd fd and commandline to load_flat_binary(), which may be used to load both the kernel & an initrd (stashing or inserting the commandline as appropriate) in the same way that load_bzimage() does. This is especially useful when load_bzimage() is unused for a particular arc