On Thu, 4 Jun 2009 06:37:19 am you wrote:
> This patch extracts the opaque data from pci i/o
> region 0 via the added VIRTIO_BLK_F_IDENTIFY
> field.
Thanks John, I fixed textual conflicts and forwarded it to Jens: he has the
other pending virtio_blk patches as well.
I removed one comment:
> +/*
This patch extracts the opaque data from pci i/o
region 0 via the added VIRTIO_BLK_F_IDENTIFY
field. By convention this data takes the form of
that returned by an ATA IDENTIFY DEVICE command,
however the driver (except for structure size)
makes no interpretation of the data. The structure
data is
Jens Axboe wrote:
> On Mon, Jun 01 2009, Rusty Russell wrote:
>> On Fri, 29 May 2009 01:45:27 pm john cooper wrote:
>>> virtio_blk-serial-4.patch
>> Hate to ask dumb questions, but is there a scsi equivalent of this? It'd be
>> nice if we could avoid being ATA-specific in the long run...
>
> SCS
On Mon, Jun 01 2009, Rusty Russell wrote:
> On Fri, 29 May 2009 01:45:27 pm john cooper wrote:
> > virtio_blk-serial-4.patch
>
> Hate to ask dumb questions, but is there a scsi equivalent of this? It'd be
> nice if we could avoid being ATA-specific in the long run...
SCSI has mode pages, where
On Fri, 29 May 2009 01:45:27 pm john cooper wrote:
> virtio_blk-serial-4.patch
Hate to ask dumb questions, but is there a scsi equivalent of this? It'd be
nice if we could avoid being ATA-specific in the long run...
Also, why u16?
Thanks,
Rusty.
> +/* return ATA identify data
> + */
> +static
On Fri, May 29, 2009 at 12:15:27AM -0400, john cooper wrote:
> virtio_blk-serial-4.patch
>
>
The patch looks good to me, but to get it applied to the kernel tree the
patch needs a good description and we also need your Signed-off-by line (See
Documentation/SubmittingPatches in the kernel source
virtio_blk-serial-4.patch
drivers/block/virtio_blk.c | 41 ++---
include/linux/virtio_blk.h |7 +++
2 files changed, 45 insertions(+), 3 deletions(-)
=
--- a/drivers/block/virtio_blk.c
>> +if (!(id = kzalloc(ATA_ID_WORDS, GFP_KERNEL)))
>> +rv = -ENOMEM;
>
> Doesn't ATA_ID_WORDS seem like a strange name for a number of bytes?
Yes I caught that bug in the rework as well.
> What's this *for* BTW?
Sorry -- I assumed you were on either list.
Please see patch to fo
Christoph Hellwig wrote:
> On Wed, May 27, 2009 at 09:49:19AM +0200, Christoph Hellwig wrote:
>> /*
>> * IDE-compatible identify ioctl.
>> *
>> * Currenlyt only returns the serial number and leaves all other fields
>> * zero.
>> */
>
> Btw, thinking about it the rest of the information in the
On Wed, 27 May 2009 05:19:19 pm Christoph Hellwig wrote:
> You should probably include rusty as he's collecting the patches
> for the virtio guest drivers.
Yes. It *does* help to cc the maintainer if you want your patches applied :)
And I particularly love untested code like this!
> + if (!
Christoph Hellwig wrote:
This looks functionally correct, but pretty far from normal kernel coding
style.
I tend to avoid 'goto's.
Christoph Hellwig wrote:
/*
* IDE-compatible identify ioctl.
*
* Currenlyt only returns the serial number and leaves all other fields
* zero.
*/
Btw, thin
On Wed, May 27, 2009 at 09:49:19AM +0200, Christoph Hellwig wrote:
> /*
> * IDE-compatible identify ioctl.
> *
> * Currenlyt only returns the serial number and leaves all other fields
> * zero.
> */
Btw, thinking about it the rest of the information in the ioctl should
probably be filled up w
You should probably include rusty as he's collecting the patches
for the virtio guest drivers.
Also can you send the patch inline next time? That makes quoting it for
review a lot easier.
drivers/block/virtio_blk.c | 32 +---
include/linux/virtio_blk.h |6 +
--
john.coo...@redhat.com
drivers/block/virtio_blk.c | 32 +---
include/linux/virtio_blk.h |6 ++
2 files changed, 35 insertions(+), 3 deletions(-)
=
--- a/drivers/block/virtio_blk.c
+++ b/driv
--
john.coo...@redhat.com
drivers/block/virtio_blk.c | 35 ---
include/linux/virtio_blk.h | 10 ++
2 files changed, 42 insertions(+), 3 deletions(-)
=
--- a/drivers/block/virtio_blk.c
+++
--
john.coo...@third-harmonic.com
drivers/block/virtio_blk.c | 36 +---
include/linux/virtio_blk.h | 10 ++
2 files changed, 43 insertions(+), 3 deletions(-)
=
--- a/include/linux/virtio_b
--
john.coo...@third-harmonic.com
drivers/block/virtio_blk.c | 36 +---
include/linux/virtio_blk.h | 10 ++
2 files changed, 43 insertions(+), 3 deletions(-)
=
--- a/include/linux/virtio_b
17 matches
Mail list logo
