Re: [PATCH 2/2] Allow the SVM CPUID bit in a VM

2008-09-03 Thread Avi Kivity
Alexander Graf wrote: I guess I didn't express myself correctly, sorry for that :-). I think that kvm kernel module capabilities should be masked out in the kernel module, while "other" stuff, like migration masking or additional CPUIDs (do these work atm?) should of course reside in the user

Re: [PATCH 2/2] Allow the SVM CPUID bit in a VM

2008-09-03 Thread Avi Kivity
Alexander Graf wrote: Needs to be predicated on a KVM_CAP_ test, so we don't enable this on older kvms. Is this a real problem? We don't allow setting SVME on older kernels anyways. Actually the kernel exports its supported cpuid bits via KVM_GET_SUPPORTED_CPUID. -- error compiling comm

Re: [PATCH 2/2] Allow the SVM CPUID bit in a VM

2008-09-03 Thread Alexander Graf
On Sep 3, 2008, at 9:55 AM, Gerd Hoffmann wrote: Hi, On a sidenote I'm really not fond of the userspace CPUID capability restrictions in the first place. Shouldn't this all be determined in the kernel module? It doesn't make since IMHO to restrict NX usage from userspace. The kernel modul

Re: [PATCH 2/2] Allow the SVM CPUID bit in a VM

2008-09-03 Thread Gerd Hoffmann
Hi, > On a sidenote I'm really not fond of the userspace CPUID capability > restrictions in the first place. Shouldn't this all be determined in the > kernel module? It doesn't make since IMHO to restrict NX usage from > userspace. The kernel module knows best what it's capable of. I think cpui

RE: [PATCH 2/2] Allow the SVM CPUID bit in a VM

2008-09-02 Thread Itamar Heim
, 2008 20:54 PM To: Alexander Graf Cc: Avi Kivity; kvm@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [PATCH 2/2] Allow the SVM CPUID bit in a VM On Sep 2, 2008, at 7:42 PM, Alexander Graf wrote: > > On Sep 1, 2008, at 4:00 PM, Avi Kivity wrote: > >> Alexa

Re: [PATCH 2/2] Allow the SVM CPUID bit in a VM

2008-09-02 Thread Alexander Graf
On Sep 2, 2008, at 7:42 PM, Alexander Graf wrote: On Sep 1, 2008, at 4:00 PM, Avi Kivity wrote: Alexander Graf wrote: Usually the qemu-kvm-bridge removes the SVM capability flag. Since KVM now supports nested SVM, this is no longer necessary. Signed-off-by: Alexander Graf <[EMAIL PROTECT

Re: [PATCH 2/2] Allow the SVM CPUID bit in a VM

2008-09-02 Thread Alexander Graf
On Sep 1, 2008, at 4:00 PM, Avi Kivity wrote: Alexander Graf wrote: Usually the qemu-kvm-bridge removes the SVM capability flag. Since KVM now supports nested SVM, this is no longer necessary. Signed-off-by: Alexander Graf <[EMAIL PROTECTED]> --- qemu/qemu-kvm-x86.c |3 --- 1 files chang

Re: [PATCH 2/2] Allow the SVM CPUID bit in a VM

2008-09-01 Thread Avi Kivity
Alexander Graf wrote: Usually the qemu-kvm-bridge removes the SVM capability flag. Since KVM now supports nested SVM, this is no longer necessary. Signed-off-by: Alexander Graf <[EMAIL PROTECTED]> --- qemu/qemu-kvm-x86.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a

[PATCH 2/2] Allow the SVM CPUID bit in a VM

2008-09-01 Thread Alexander Graf
Usually the qemu-kvm-bridge removes the SVM capability flag. Since KVM now supports nested SVM, this is no longer necessary. Signed-off-by: Alexander Graf <[EMAIL PROTECTED]> --- qemu/qemu-kvm-x86.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/qemu/qemu-kvm-x86.c b/q