Re: [PATCH 2/2] Remove -tdf

2008-07-27 Thread Avi Kivity
Anthony Liguori wrote: I think there's a healthy amount of scepticism about whether tdf really is worth it. This is why I suggested that we need to better quantify exactly how much this patch set helps things. For instance, a time drift test for kvm-autotest would be perfect. tdf is ugly

Re: [PATCH 2/2] Remove -tdf

2008-07-27 Thread Avi Kivity
Anthony Liguori wrote: The last time I posted the KVM patch series to qemu-devel, the -tdf patch met with some opposition. Since today we implement timer catch-up in the in-kernel PIT and the in-kernel PIT is used by default, it doesn't seem all that valuable to have timer catch-up in userspac

Re: [PATCH 2/2] Remove -tdf

2008-07-24 Thread Dor Laor
Anthony Liguori wrote: Gleb Natapov wrote: On Tue, Jul 22, 2008 at 08:20:41PM -0500, Anthony Liguori wrote: Currently both in-kernel PIT and even the in kernel irqchips are not 100% bullet proof. Of course this code is a hack, Gleb Natapov has send better fix for PIT/RTC to qemu list. Can

Re: [PATCH 2/2] Remove -tdf

2008-07-23 Thread Anthony Liguori
Gleb Natapov wrote: On Tue, Jul 22, 2008 at 08:20:41PM -0500, Anthony Liguori wrote: Currently both in-kernel PIT and even the in kernel irqchips are not 100% bullet proof. Of course this code is a hack, Gleb Natapov has send better fix for PIT/RTC to qemu list. Can you look into them: ht

Re: [PATCH 2/2] Remove -tdf

2008-07-22 Thread Gleb Natapov
On Tue, Jul 22, 2008 at 08:20:41PM -0500, Anthony Liguori wrote: >> Currently both in-kernel PIT and even the in kernel irqchips are not >> 100% bullet proof. >> Of course this code is a hack, Gleb Natapov has send better fix for >> PIT/RTC to qemu list. >> Can you look into them: >> http://www

Re: [PATCH 2/2] Remove -tdf

2008-07-22 Thread David S. Ahern
Anthony Liguori wrote: > Dor Laor wrote: >> Anthony Liguori wrote: >>> The last time I posted the KVM patch series to qemu-devel, the -tdf >>> patch met with >>> some opposition. Since today we implement timer catch-up in the >>> in-kernel PIT and >>> the in-kernel PIT is used by default, it doe

Re: [PATCH 2/2] Remove -tdf

2008-07-22 Thread Anthony Liguori
Dor Laor wrote: Anthony Liguori wrote: The last time I posted the KVM patch series to qemu-devel, the -tdf patch met with some opposition. Since today we implement timer catch-up in the in-kernel PIT and the in-kernel PIT is used by default, it doesn't seem all that valuable to have timer ca

Re: [PATCH 2/2] Remove -tdf

2008-07-22 Thread Dor Laor
Anthony Liguori wrote: The last time I posted the KVM patch series to qemu-devel, the -tdf patch met with some opposition. Since today we implement timer catch-up in the in-kernel PIT and the in-kernel PIT is used by default, it doesn't seem all that valuable to have timer catch-up in userspac

[PATCH 2/2] Remove -tdf

2008-07-22 Thread Anthony Liguori
The last time I posted the KVM patch series to qemu-devel, the -tdf patch met with some opposition. Since today we implement timer catch-up in the in-kernel PIT and the in-kernel PIT is used by default, it doesn't seem all that valuable to have timer catch-up in userspace too. Removing it will