Re: [PATCH 2/2] fix compilation with --disable-kvm

2008-10-02 Thread Avi Kivity
Glauber Costa wrote: On Thu, Oct 02, 2008 at 04:43:06PM +0300, Avi Kivity wrote: Glauber Costa wrote: -kvm_save_registers(mon_cpu); +if (kvm_enabled()) +kvm_save_registers(mon_cpu); If I'm not mistaken, this relies on the optimizer to remove the call to kvm

Re: [PATCH 2/2] fix compilation with --disable-kvm

2008-10-02 Thread Glauber Costa
On Thu, Oct 02, 2008 at 04:43:06PM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> -kvm_save_registers(mon_cpu); >> +if (kvm_enabled()) >> +kvm_save_registers(mon_cpu); >> > > If I'm not mistaken, this relies on the optimizer to remove the call to > kvm_save_registers().

Re: [PATCH 2/2] fix compilation with --disable-kvm

2008-10-02 Thread Avi Kivity
Glauber Costa wrote: -kvm_save_registers(mon_cpu); +if (kvm_enabled()) +kvm_save_registers(mon_cpu); If I'm not mistaken, this relies on the optimizer to remove the call to kvm_save_registers(). Compilation with -O0 will break. I think a better solution is to have kvm

[PATCH 2/2] fix compilation with --disable-kvm

2008-10-02 Thread Glauber Costa
Currently, kvm is failing to build with --disable-kvm. this patch fixes the issue. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/gdbstub.c | 15 ++- qemu/hw/acpi.c |6 +- qemu/hw/cirrus_vga.c |7 +++ qemu/monitor.c |6 -- 4 files