Re: [PATCH 2/2] pci: allow sysfs file owner to read device dependent config space

2010-05-14 Thread Jesse Barnes
On Fri, 14 May 2010 12:09:23 -0700 Greg KH wrote: > On Wed, May 12, 2010 at 06:29:57PM -0700, Chris Wright wrote: > > The PCI config space bin_attr read handler has a hardcoded CAP_SYS_ADMIN > > check to verify privileges before allowing a user to read device > > dependent config space. This is

Re: [PATCH 2/2] pci: allow sysfs file owner to read device dependent config space

2010-05-14 Thread Greg KH
On Wed, May 12, 2010 at 06:29:57PM -0700, Chris Wright wrote: > The PCI config space bin_attr read handler has a hardcoded CAP_SYS_ADMIN > check to verify privileges before allowing a user to read device > dependent config space. This is meant to protect from an unprivileged > user potentially loc

Re: [PATCH 2/2] pci: allow sysfs file owner to read device dependent config space

2010-05-13 Thread Chris Wright
* Alan Cox (a...@lxorguk.ukuu.org.uk) wrote: > On Wed, 12 May 2010 18:29:57 -0700 > Chris Wright wrote: > > > The PCI config space bin_attr read handler has a hardcoded CAP_SYS_ADMIN > > check to verify privileges before allowing a user to read device > > dependent config space. This is meant to

Re: [PATCH 2/2] pci: allow sysfs file owner to read device dependent config space

2010-05-13 Thread Daniel P. Berrange
On Thu, May 13, 2010 at 01:56:53PM +0300, Avi Kivity wrote: > On 05/13/2010 04:29 AM, Chris Wright wrote: > >The PCI config space bin_attr read handler has a hardcoded CAP_SYS_ADMIN > >check to verify privileges before allowing a user to read device > >dependent config space. This is meant to prot

Re: [PATCH 2/2] pci: allow sysfs file owner to read device dependent config space

2010-05-13 Thread Avi Kivity
On 05/13/2010 04:29 AM, Chris Wright wrote: The PCI config space bin_attr read handler has a hardcoded CAP_SYS_ADMIN check to verify privileges before allowing a user to read device dependent config space. This is meant to protect from an unprivileged user potentially locking up the box. When a

Re: [PATCH 2/2] pci: allow sysfs file owner to read device dependent config space

2010-05-13 Thread Alan Cox
On Wed, 12 May 2010 18:29:57 -0700 Chris Wright wrote: > The PCI config space bin_attr read handler has a hardcoded CAP_SYS_ADMIN > check to verify privileges before allowing a user to read device > dependent config space. This is meant to protect from an unprivileged > user potentially locking

[PATCH 2/2] pci: allow sysfs file owner to read device dependent config space

2010-05-12 Thread Chris Wright
The PCI config space bin_attr read handler has a hardcoded CAP_SYS_ADMIN check to verify privileges before allowing a user to read device dependent config space. This is meant to protect from an unprivileged user potentially locking up the box. When assigning a PCI device directly to a guest with