Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Glauber Costa
On Thu, Oct 15, 2009 at 06:06:04PM +0200, Jan Kiszka wrote: > Glauber Costa wrote: > > On Thu, Oct 15, 2009 at 05:11:27PM +0900, Avi Kivity wrote: > >> On 10/14/2009 01:06 AM, Jan Kiszka wrote: > >>> Add a new IOCTL pair to retrieve or set the VCPU state in one chunk. > >>> More precisely, the IOCT

Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Jan Kiszka
Glauber Costa wrote: > On Thu, Oct 15, 2009 at 05:11:27PM +0900, Avi Kivity wrote: >> On 10/14/2009 01:06 AM, Jan Kiszka wrote: >>> Add a new IOCTL pair to retrieve or set the VCPU state in one chunk. >>> More precisely, the IOCTL is able to process a list of substates to be >>> read or written. Th

Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Glauber Costa
On Thu, Oct 15, 2009 at 05:11:27PM +0900, Avi Kivity wrote: > On 10/14/2009 01:06 AM, Jan Kiszka wrote: >> Add a new IOCTL pair to retrieve or set the VCPU state in one chunk. >> More precisely, the IOCTL is able to process a list of substates to be >> read or written. This list is easily extensibl

Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Glauber Costa
On Thu, Oct 15, 2009 at 05:11:27PM +0900, Avi Kivity wrote: > On 10/14/2009 01:06 AM, Jan Kiszka wrote: >> Add a new IOCTL pair to retrieve or set the VCPU state in one chunk. >> More precisely, the IOCTL is able to process a list of substates to be >> read or written. This list is easily extensibl

Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Avi Kivity
On 10/15/2009 06:22 PM, Jan Kiszka wrote: Better to split sse from fpu since we already know it is about to be replaced. The idea is to reuse the existing state structures, including struct kvm_fpu. This allows to provide the avoid substates for all archs and simplifies the migration (see

Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Jan Kiszka
Avi Kivity wrote: > On 10/14/2009 01:06 AM, Jan Kiszka wrote: >> Add a new IOCTL pair to retrieve or set the VCPU state in one chunk. >> More precisely, the IOCTL is able to process a list of substates to be >> read or written. This list is easily extensible without breaking the >> existing ABI, th

Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Jan Kiszka
Avi Kivity wrote: > On 10/14/2009 01:06 AM, Jan Kiszka wrote: >> @@ -1586,6 +1719,7 @@ static long kvm_dev_ioctl_check_extension_generic(long >> arg) >> case KVM_CAP_USER_MEMORY: >> case KVM_CAP_DESTROY_MEMORY_REGION_WORKS: >> case KVM_CAP_JOIN_MEMORY_REGIONS_WORKS: >> +case KVM

Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Jan Kiszka
Avi Kivity wrote: > On 10/14/2009 01:06 AM, Jan Kiszka wrote: >> Add a new IOCTL pair to retrieve or set the VCPU state in one chunk. >> More precisely, the IOCTL is able to process a list of substates to be >> read or written. This list is easily extensible without breaking the >> existing ABI, th

Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Avi Kivity
On 10/14/2009 01:06 AM, Jan Kiszka wrote: Add a new IOCTL pair to retrieve or set the VCPU state in one chunk. More precisely, the IOCTL is able to process a list of substates to be read or written. This list is easily extensible without breaking the existing ABI, thus we will no longer have to a

Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Avi Kivity
On 10/14/2009 01:06 AM, Jan Kiszka wrote: @@ -1586,6 +1719,7 @@ static long kvm_dev_ioctl_check_extension_generic(long arg) case KVM_CAP_USER_MEMORY: case KVM_CAP_DESTROY_MEMORY_REGION_WORKS: case KVM_CAP_JOIN_MEMORY_REGIONS_WORKS: + case KVM_CAP_VCPU_STATE: #ifde

Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-15 Thread Avi Kivity
On 10/14/2009 01:06 AM, Jan Kiszka wrote: Add a new IOCTL pair to retrieve or set the VCPU state in one chunk. More precisely, the IOCTL is able to process a list of substates to be read or written. This list is easily extensible without breaking the existing ABI, thus we will no longer have to a

[PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

2009-10-13 Thread Jan Kiszka
Add a new IOCTL pair to retrieve or set the VCPU state in one chunk. More precisely, the IOCTL is able to process a list of substates to be read or written. This list is easily extensible without breaking the existing ABI, thus we will no longer have to add new IOCTLs when we discover a missing VCP