Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-19 Thread Gleb Natapov
On Wed, Dec 19, 2012 at 12:01:19AM +0100, Alexander Graf wrote: On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants a BUG(), because it can be

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-19 Thread Alexander Graf
On 19.12.2012, at 10:37, Gleb Natapov wrote: On Wed, Dec 19, 2012 at 12:01:19AM +0100, Alexander Graf wrote: On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-19 Thread Gleb Natapov
On Wed, Dec 19, 2012 at 10:59:28AM +0100, Alexander Graf wrote: On 19.12.2012, at 10:37, Gleb Natapov wrote: On Wed, Dec 19, 2012 at 12:01:19AM +0100, Alexander Graf wrote: On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-19 Thread Gleb Natapov
On Wed, Dec 19, 2012 at 12:01:19AM +0100, Alexander Graf wrote: On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants a BUG(), because it can be

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-19 Thread Alexander Graf
On 19.12.2012, at 10:37, Gleb Natapov wrote: On Wed, Dec 19, 2012 at 12:01:19AM +0100, Alexander Graf wrote: On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-19 Thread Gleb Natapov
On Wed, Dec 19, 2012 at 10:59:28AM +0100, Alexander Graf wrote: On 19.12.2012, at 10:37, Gleb Natapov wrote: On Wed, Dec 19, 2012 at 12:01:19AM +0100, Alexander Graf wrote: On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an

[PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-18 Thread Alexander Graf
When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants a BUG(), because it can be guest triggered. So instead, let's only WARN() the user that this happened. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/powerpc.c |3 ++- 1

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-18 Thread Scott Wood
On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants a BUG(), because it can be guest triggered. So instead, let's only WARN() the user that this happened. Signed-off-by: Alexander Graf

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-18 Thread Alexander Graf
On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants a BUG(), because it can be guest triggered. So instead, let's only WARN() the user that this

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-18 Thread Scott Wood
On 12/18/2012 05:01:19 PM, Alexander Graf wrote: On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants a BUG(), because it can be guest

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-18 Thread Alexander Graf
On 19.12.2012, at 00:05, Scott Wood wrote: On 12/18/2012 05:01:19 PM, Alexander Graf wrote: On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants

[PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-18 Thread Alexander Graf
When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants a BUG(), because it can be guest triggered. So instead, let's only WARN() the user that this happened. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/powerpc.c |3 ++- 1

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-18 Thread Scott Wood
On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants a BUG(), because it can be guest triggered. So instead, let's only WARN() the user that this happened. Signed-off-by: Alexander Graf

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-18 Thread Alexander Graf
On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants a BUG(), because it can be guest triggered. So instead, let's only WARN() the user that this

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-18 Thread Scott Wood
On 12/18/2012 05:01:19 PM, Alexander Graf wrote: On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants a BUG(), because it can be guest

Re: [PATCH 2/4] KVM: PPC: Only WARN on invalid emulation

2012-12-18 Thread Alexander Graf
On 19.12.2012, at 00:05, Scott Wood wrote: On 12/18/2012 05:01:19 PM, Alexander Graf wrote: On 18.12.2012, at 23:54, Scott Wood wrote: On 12/18/2012 06:38:41 AM, Alexander Graf wrote: When we hit an emulation result that we didn't expect, that is an error, but it's nothing that warrants