[PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-01 Thread Jan Kiszka
This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel before vmsave) - cpu_synchronize_all_post_init in qemu_loadvm_state (writeback after vmload)

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-01 Thread Marcelo Tosatti
On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: > This grand cleanup drops all reset and vmsave/load related > synchronization points in favor of four(!) generic hooks: > > - cpu_synchronize_all_states in qemu_savevm_state_complete > (initial sync from kernel before vmsave) > - cpu_s

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-02 Thread Jan Kiszka
Marcelo Tosatti wrote: > On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: >> This grand cleanup drops all reset and vmsave/load related >> synchronization points in favor of four(!) generic hooks: >> >> - cpu_synchronize_all_states in qemu_savevm_state_complete >> (initial sync from ke

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-02 Thread Marcelo Tosatti
On Tue, Mar 02, 2010 at 09:00:04AM +0100, Jan Kiszka wrote: > Marcelo Tosatti wrote: > > On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: > >> This grand cleanup drops all reset and vmsave/load related > >> synchronization points in favor of four(!) generic hooks: > >> > >> - cpu_synchro

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-02 Thread Jan Kiszka
Marcelo Tosatti wrote: > On Tue, Mar 02, 2010 at 09:00:04AM +0100, Jan Kiszka wrote: >> Marcelo Tosatti wrote: >>> On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hook

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-02 Thread Marcelo Tosatti
On Tue, Mar 02, 2010 at 05:31:09PM +0100, Jan Kiszka wrote: > Marcelo Tosatti wrote: > > On Tue, Mar 02, 2010 at 09:00:04AM +0100, Jan Kiszka wrote: > >> Marcelo Tosatti wrote: > >>> On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: > This grand cleanup drops all reset and vmsave/loa

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-03 Thread Marcelo Tosatti
On Tue, Mar 02, 2010 at 11:29:10PM -0300, Marcelo Tosatti wrote: > On Tue, Mar 02, 2010 at 05:31:09PM +0100, Jan Kiszka wrote: > > Marcelo Tosatti wrote: > > > On Tue, Mar 02, 2010 at 09:00:04AM +0100, Jan Kiszka wrote: > > >> Marcelo Tosatti wrote: > > >>> On Mon, Mar 01, 2010 at 07:10:30PM +0100,

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-03 Thread Kevin O'Connor
On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: > The regression seems to be caused by seabios commit d7e998f. Kevin, the > failure can be seen on the attached screenshot, which happens on the > first reboot of WinXP 32 installation (after copying files etc). Sorry - I also notice

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-04 Thread Marcelo Tosatti
On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote: > On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: > > The regression seems to be caused by seabios commit d7e998f. Kevin, the > > failure can be seen on the attached screenshot, which happens on the > > first reboot of

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-05 Thread Kevin O'Connor
On Thu, Mar 04, 2010 at 03:35:52PM -0300, Marcelo Tosatti wrote: > On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote: > > On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: > > > The regression seems to be caused by seabios commit d7e998f. Kevin, the > > > failure can be

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-08 Thread Marcelo Tosatti
On Fri, Mar 05, 2010 at 09:37:26PM -0500, Kevin O'Connor wrote: > On Thu, Mar 04, 2010 at 03:35:52PM -0300, Marcelo Tosatti wrote: > > On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote: > > > On Thu, Mar 04, 2010 at 01:21:12AM -0300, Marcelo Tosatti wrote: > > > > The regression seems

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-09 Thread Anthony Liguori
On 03/08/2010 02:33 PM, Marcelo Tosatti wrote: On Fri, Mar 05, 2010 at 09:37:26PM -0500, Kevin O'Connor wrote: On Thu, Mar 04, 2010 at 03:35:52PM -0300, Marcelo Tosatti wrote: On Thu, Mar 04, 2010 at 12:58:58AM -0500, Kevin O'Connor wrote: On Thu, Mar 04, 2010 at 01:21:12AM -

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-11 Thread Avi Kivity
On 03/02/2010 02:14 AM, Marcelo Tosatti wrote: On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (init

Re: [PATCH 2/4] KVM: Rework VCPU state writeback API

2010-03-11 Thread Marcelo Tosatti
On Thu, Mar 11, 2010 at 10:32:50AM +0200, Avi Kivity wrote: > On 03/02/2010 02:14 AM, Marcelo Tosatti wrote: > >On Mon, Mar 01, 2010 at 07:10:30PM +0100, Jan Kiszka wrote: > >>This grand cleanup drops all reset and vmsave/load related > >>synchronization points in favor of four(!) generic hooks: >