[PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

2012-06-26 Thread Namhyung Kim
From: Namhyung Kim The kvm_emulate_insn tracepoint used __print_insn() for printing its instructions. However it makes the format of the event hard to parse as it reveals TP internals. Fortunately, kernel provides __print_hex for almost same purpose, we can use it instead of open coding it. The

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

2012-06-27 Thread Steven Rostedt
[ Added Avi] On Wed, 2012-06-27 at 09:41 +0900, Namhyung Kim wrote: > From: Namhyung Kim > > The kvm_emulate_insn tracepoint used __print_insn() > for printing its instructions. However it makes the > format of the event hard to parse as it reveals TP > internals. > > Fortunately, kernel provid

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

2012-06-27 Thread Avi Kivity
On 06/27/2012 03:49 PM, Steven Rostedt wrote: > [ Added Avi] > > On Wed, 2012-06-27 at 09:41 +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> >> The kvm_emulate_insn tracepoint used __print_insn() >> for printing its instructions. However it makes the >> format of the event hard to parse as i

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

2012-06-27 Thread Steven Rostedt
On Wed, 2012-06-27 at 15:54 +0300, Avi Kivity wrote: > Acked-by: Avi Kivity Thanks Avi! > > Some time ago we discussed moving the trace-cmd plugins to /lib/modules, > which would make this trace display as "mov %edx,(%eax)" instead of "89 > 10", even for non-trace-cmd users. Was there any mov

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

2012-06-27 Thread Namhyung Kim
[CC'ing David] Hi, Steve On Wed, 27 Jun 2012 09:20:24 -0400, Steven Rostedt wrote: > On Wed, 2012-06-27 at 15:54 +0300, Avi Kivity wrote: > >> Acked-by: Avi Kivity > > Thanks Avi! > Can you give me your ack's too (for this and other ones in the series)? And if you ok, I can route this and futur

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

2012-06-27 Thread Steven Rostedt
On Thu, 2012-06-28 at 10:16 +0900, Namhyung Kim wrote: > [CC'ing David] > > Hi, Steve > > On Wed, 27 Jun 2012 09:20:24 -0400, Steven Rostedt wrote: > > On Wed, 2012-06-27 at 15:54 +0300, Avi Kivity wrote: > > > >> Acked-by: Avi Kivity > > > > Thanks Avi! > > > > Can you give me your ack's too (

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

2012-06-27 Thread Namhyung Kim
On Wed, 27 Jun 2012 21:52:44 -0400, Steven Rostedt wrote: > On Thu, 2012-06-28 at 10:16 +0900, Namhyung Kim wrote: >> [CC'ing David] >> >> Hi, Steve >> >> On Wed, 27 Jun 2012 09:20:24 -0400, Steven Rostedt wrote: >> > On Wed, 2012-06-27 at 15:54 +0300, Avi Kivity wrote: >> > >> >> Acked-by: Avi K

Re: [PATCH 2/4] KVM: Use __print_hex() for kvm_emulate_insn tracepoint

2012-06-27 Thread Steven Rostedt
On Thu, 2012-06-28 at 10:59 +0900, Namhyung Kim wrote: > Ok, thanks. But how about other ones? Did you add all of 4 into you > queue? Ah, no I didn't. I actually would like Arnaldo to do that. Arnaldo, Can you pull patches 1,3 & 4 into your repo, and add my: Acked-by: Steven Rostedt Thanks!