Re: [PATCH 2/5] virtio: support unlocked queue kick

2011-11-02 Thread Minchan Kim
Hi Christoph, On Wed, Oct 05, 2011 at 03:54:05PM -0400, Christoph Hellwig wrote: > Split virtqueue_kick to be able to do the actual notification outside the > lock protecting the virtqueue. This patch was originally done by Nitpick: Until now, virtqueue_kick is called under lock, still so descr

Re: [PATCH 2/5] virtio: support unlocked queue kick

2011-11-02 Thread Rusty Russell
On Thu, 03 Nov 2011 14:31:48 +1030, Rusty Russell wrote: > So let's change the API for everyone, into: > > bool virtqueue_should_kick(struct virtqueue *vq); > void virtqueue_kick(struct virtqueue *vq); > > Patch series coming... Nope, that sucked. virtqueue_should_kick() has si

Re: [PATCH 2/5] virtio: support unlocked queue kick

2011-11-02 Thread Rusty Russell
On Wed, 2 Nov 2011 03:25:44 -0400, Christoph Hellwig wrote: > On Wed, Nov 02, 2011 at 01:49:36PM +1030, Rusty Russell wrote: > > I thought it was still a WIP? > > The whole series - yes. This patch (and the serial number rewrite): no > - these are pretty much rock solid. OK, thanks. > > Since

Re: [PATCH 2/5] virtio: support unlocked queue kick

2011-11-02 Thread Christoph Hellwig
On Wed, Nov 02, 2011 at 01:49:36PM +1030, Rusty Russell wrote: > I thought it was still a WIP? The whole series - yes. This patch (and the serial number rewrite): no - these are pretty much rock solid. > Since the problem is contention on the lock inside the block layer, the > simplest solution

Re: [PATCH 2/5] virtio: support unlocked queue kick

2011-11-01 Thread Rusty Russell
On Tue, 1 Nov 2011 16:40:45 +0200, "Michael S. Tsirkin" wrote: > On Thu, Oct 06, 2011 at 11:18:28AM -0200, Michael S. Tsirkin wrote: > > On Thu, Oct 06, 2011 at 12:15:36PM +1030, Rusty Russell wrote: > > > On Wed, 05 Oct 2011 15:54:05 -0400, Christoph Hellwig > > > wrote: > > > > Split virtqueue

Re: [PATCH 2/5] virtio: support unlocked queue kick

2011-11-01 Thread Michael S. Tsirkin
On Thu, Oct 06, 2011 at 11:18:28AM -0200, Michael S. Tsirkin wrote: > On Thu, Oct 06, 2011 at 12:15:36PM +1030, Rusty Russell wrote: > > On Wed, 05 Oct 2011 15:54:05 -0400, Christoph Hellwig > > wrote: > > > Split virtqueue_kick to be able to do the actual notification outside the > > > lock prot

Re: [PATCH 2/5] virtio: support unlocked queue kick

2011-10-06 Thread Michael S. Tsirkin
On Thu, Oct 06, 2011 at 12:15:36PM +1030, Rusty Russell wrote: > On Wed, 05 Oct 2011 15:54:05 -0400, Christoph Hellwig > wrote: > > Split virtqueue_kick to be able to do the actual notification outside the > > lock protecting the virtqueue. This patch was originally done by > > Stefan Hajnoczi,

Re: [PATCH 2/5] virtio: support unlocked queue kick

2011-10-06 Thread Stefan Hajnoczi
On Wed, Oct 05, 2011 at 03:54:05PM -0400, Christoph Hellwig wrote: > Split virtqueue_kick to be able to do the actual notification outside the > lock protecting the virtqueue. This patch was originally done by > Stefan Hajnoczi, but I can't find the original one anymore and had to > recreated it f

[PATCH 2/5] virtio: support unlocked queue kick

2011-10-05 Thread Christoph Hellwig
Split virtqueue_kick to be able to do the actual notification outside the lock protecting the virtqueue. This patch was originally done by Stefan Hajnoczi, but I can't find the original one anymore and had to recreated it from memory. Pointers to the original or corrections for the commit message