Re: [PATCH 3/3] Add KVM support to QEMU

2008-11-04 Thread Avi Kivity
Anthony Liguori wrote: I think live migration is now broken, since kvm accesses will not update the qemu dirty bitmap. Eh? I don't follow you here. guest writes in qemu set the qemu dirty bitmap (for cpu_physical_memory_get_dirty()), but guest accesses in kvm won't, unless you enable

Re: [PATCH 3/3] Add KVM support to QEMU

2008-11-04 Thread Anthony Liguori
Avi Kivity wrote: Anthony Liguori wrote: I think live migration is now broken, since kvm accesses will not update the qemu dirty bitmap. Eh? I don't follow you here. guest writes in qemu set the qemu dirty bitmap (for cpu_physical_memory_get_dirty()), but guest accesses in kvm won't,

Re: [PATCH 3/3] Add KVM support to QEMU

2008-11-04 Thread Avi Kivity
Anthony Liguori wrote: This patch adds very basic KVM support. KVM is a kernel module for Linux that allows userspace programs to make use of hardware virtualization support. It current supports x86 hardware virtualization using Intel VT-x or AMD-V. It also supports IA64 VT-i, PPC 440, and

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Avi Kivity
Anthony Liguori wrote: Another place hook is updating a slot's dirty bitmap. Right now, with my patchset we don't have live migration or the VGA RAM optimization. There's nothing about the VGA RAM optimization that wouldn't work for QEMU. I'm not sure that it really is an optimization in

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Glauber Costa
On Wed, Oct 29, 2008 at 11:54:11AM +0200, Avi Kivity wrote: Anthony Liguori wrote: Another place hook is updating a slot's dirty bitmap. Right now, with my patchset we don't have live migration or the VGA RAM optimization. There's nothing about the VGA RAM optimization that wouldn't

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Avi Kivity
Glauber Costa wrote: Another place hook is updating a slot's dirty bitmap. Right now, with my patchset we don't have live migration or the VGA RAM optimization. There's nothing about the VGA RAM optimization that wouldn't work for QEMU. I'm not sure that it really is an optimization in

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Glauber Costa
On Wed, Oct 29, 2008 at 02:39:57PM +0200, Avi Kivity wrote: Glauber Costa wrote: Another place hook is updating a slot's dirty bitmap. Right now, with my patchset we don't have live migration or the VGA RAM optimization. There's nothing about the VGA RAM optimization that wouldn't

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Anthony Liguori
Avi Kivity wrote: Anthony Liguori wrote: Another place hook is updating a slot's dirty bitmap. Right now, with my patchset we don't have live migration or the VGA RAM optimization. There's nothing about the VGA RAM optimization that wouldn't work for QEMU. I'm not sure that it really is an

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Avi Kivity
Anthony Liguori wrote: Avi Kivity wrote: Anthony Liguori wrote: Another place hook is updating a slot's dirty bitmap. Right now, with my patchset we don't have live migration or the VGA RAM optimization. There's nothing about the VGA RAM optimization that wouldn't work for QEMU. I'm not

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Anthony Liguori
Avi Kivity wrote: Anthony Liguori wrote: Avi Kivity wrote: Anthony Liguori wrote: Another place hook is updating a slot's dirty bitmap. Right now, with my patchset we don't have live migration or the VGA RAM optimization. There's nothing about the VGA RAM optimization that wouldn't work

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Hollis Blanchard
On Tue, Oct 28, 2008 at 6:36 PM, Anthony Liguori [EMAIL PROTECTED] wrote: Something I was thinking about this morning, and I think the first place where we'll definitely need a hook, is how to deal with kvm_load_registers(). I think there's overlap between KVM and the IO thread here. There

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Avi Kivity
Hollis Blanchard wrote: On Tue, Oct 28, 2008 at 6:36 PM, Anthony Liguori [EMAIL PROTECTED] wrote: Something I was thinking about this morning, and I think the first place where we'll definitely need a hook, is how to deal with kvm_load_registers(). I think there's overlap between KVM and

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Anthony Liguori
Fabrice Bellard wrote: Avi Kivity wrote: Hollis Blanchard wrote: Out of curiosity, where are those places? local apic -- needs to access interrupt disable flag acpi sleep -- halts the current processor, so tied to cpustate vmport -- bad ABI requires access to registers

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Fabrice Bellard
Avi Kivity wrote: Hollis Blanchard wrote: On Tue, Oct 28, 2008 at 6:36 PM, Anthony Liguori [EMAIL PROTECTED] wrote: Something I was thinking about this morning, and I think the first place where we'll definitely need a hook, is how to deal with kvm_load_registers(). I think there's

Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Glauber Costa
resending, now with less quoted text: diff --git a/kvm-all.c b/kvm-all.c new file mode 100644 index 000..4379071 --- /dev/null +++ b/kvm-all.c @@ -0,0 +1,377 @@ +/* + * QEMU KVM support + * + * Copyright IBM, Corp. 2008 + * + * Authors: + * Anthony Liguori [EMAIL PROTECTED] +

Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Anthony Liguori
Glauber Costa wrote: resending, now with less quoted text: Yeah, I was intending to scold you about that ;-) diff --git a/kvm-all.c b/kvm-all.c new file mode 100644 index 000..4379071 --- /dev/null +++ b/kvm-all.c @@ -0,0 +1,377 @@ +/* + * QEMU KVM support + * + * Copyright IBM, Corp.

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-29 Thread Blue Swirl
On 10/29/08, Avi Kivity [EMAIL PROTECTED] wrote: Hollis Blanchard wrote: On Tue, Oct 28, 2008 at 6:36 PM, Anthony Liguori [EMAIL PROTECTED] wrote: Something I was thinking about this morning, and I think the first place where we'll definitely need a hook, is how to deal with

Re: [Qemu-devel] [PATCH 3/3] Add KVM support to QEMU

2008-10-28 Thread Anthony Liguori
Hollis Blanchard wrote: Just a quick skim... On Tue, Oct 28, 2008 at 3:13 PM, Anthony Liguori [EMAIL PROTECTED] wrote: +int kvm_cpu_exec(CPUState *env) +{ +struct kvm_run *run = env-kvm_run; +int ret; + +dprintf(kvm_cpu_exec()\n); + +do { +kvm_arch_pre_run(env, run);

Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-28 Thread Gerd Hoffmann
Anthony Liguori wrote: This patch only implements the bare minimum support to get a guest booting. It has very little impact the rest of QEMU and attempts to integrate nicely with the rest of QEMU. Huh? That isn't based on the qemu-accel patches ... surprised, Gerd -- To unsubscribe

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-28 Thread Glauber Costa
On Tue, Oct 28, 2008 at 7:51 PM, Anthony Liguori [EMAIL PROTECTED] wrote: Gerd Hoffmann wrote: Anthony Liguori wrote: This patch only implements the bare minimum support to get a guest booting. It has very little impact the rest of QEMU and attempts to integrate nicely with the rest of

Re: [Qemu-devel] Re: [PATCH 3/3] Add KVM support to QEMU

2008-10-28 Thread Anthony Liguori
Glauber Costa wrote: On Tue, Oct 28, 2008 at 7:51 PM, Anthony Liguori [EMAIL PROTECTED] wrote: This is part of the reason for this exercise. I'd rather introduce KVM support first and then look at abstracting things, than vice versa. A number of the hooks in the current QEMUAccel tree are

Re: [Qemu-devel] [PATCH 3/3] Add KVM support to QEMU

2008-10-28 Thread Anthony Liguori
Hollis Blanchard wrote: Just a quick skim... On Tue, Oct 28, 2008 at 3:13 PM, Anthony Liguori [EMAIL PROTECTED] wrote: +int kvm_cpu_exec(CPUState *env) +{ +struct kvm_run *run = env-kvm_run; +int ret; + +dprintf(kvm_cpu_exec()\n); + +do { +kvm_arch_pre_run(env, run);