Re: [PATCH 3/3] KVM: ARM: Transparent huge pages and hugetlbfs support

2013-10-04 Thread Marc Zyngier
On 2013-10-03 21:33, Christoffer Dall wrote: On Mon, Sep 23, 2013 at 11:11:07AM +0100, Marc Zyngier wrote: [...] > > +static bool transparent_hugepage_adjust(pfn_t *pfnp, phys_addr_t *ipap) > +{ > + pfn_t pfn = *pfnp; > + gfn_t gfn = *ipap >> PAGE_SHIFT; > + > + if (PageTra

Re: [PATCH 3/3] KVM: ARM: Transparent huge pages and hugetlbfs support

2013-10-03 Thread Christoffer Dall
On Mon, Sep 23, 2013 at 11:11:07AM +0100, Marc Zyngier wrote: [...] > > > > +static bool transparent_hugepage_adjust(pfn_t *pfnp, phys_addr_t *ipap) > > +{ > > + pfn_t pfn = *pfnp; > > + gfn_t gfn = *ipap >> PAGE_SHIFT; > > + > > + if (PageTransCompound(pfn_to_page(pfn))) { > >

Re: [PATCH 3/3] KVM: ARM: Transparent huge pages and hugetlbfs support

2013-10-02 Thread Christoffer Dall
On Mon, Sep 23, 2013 at 11:11:07AM +0100, Marc Zyngier wrote: > Hi Christoffer, > > Finally taking some time to review this patch. Sorry for the delay... > > On 09/08/13 05:07, Christoffer Dall wrote: > > From: Christoffer Dall > > > > Support transparent huge pages in KVM/ARM 32-bit and 64-bit

Re: [PATCH 3/3] KVM: ARM: Transparent huge pages and hugetlbfs support

2013-09-24 Thread Steve Capper
On Mon, Sep 23, 2013 at 11:11:07AM +0100, Marc Zyngier wrote: > Hi Christoffer, > > Finally taking some time to review this patch. Sorry for the delay... > > On 09/08/13 05:07, Christoffer Dall wrote: > > From: Christoffer Dall > > [ snip ] > > static int user_mem_abort(struct kvm_vcpu *vcpu

Re: [PATCH 3/3] KVM: ARM: Transparent huge pages and hugetlbfs support

2013-09-23 Thread Marc Zyngier
On 23/09/13 11:11, Marc Zyngier wrote: > Hi Christoffer, > > Finally taking some time to review this patch. Sorry for the delay... > > On 09/08/13 05:07, Christoffer Dall wrote: >> From: Christoffer Dall >> >> Support transparent huge pages in KVM/ARM 32-bit and 64-bit. The whole >> transparent

Re: [PATCH 3/3] KVM: ARM: Transparent huge pages and hugetlbfs support

2013-09-23 Thread Marc Zyngier
Hi Christoffer, Finally taking some time to review this patch. Sorry for the delay... On 09/08/13 05:07, Christoffer Dall wrote: > From: Christoffer Dall > > Support transparent huge pages in KVM/ARM 32-bit and 64-bit. The whole > transparent_hugepage_adjust stuff is far from pretty, but this

[PATCH 3/3] KVM: ARM: Transparent huge pages and hugetlbfs support

2013-08-08 Thread Christoffer Dall
From: Christoffer Dall Support transparent huge pages in KVM/ARM 32-bit and 64-bit. The whole transparent_hugepage_adjust stuff is far from pretty, but this is how it's solved on x86 so we duplicate their logic. This should be shared across architectures if possible (like many other things), bu