Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-05-02 Thread Alexander Graf
On 02.05.2013, at 13:00, Gleb Natapov wrote: > On Thu, May 02, 2013 at 12:53:44PM +0200, Alexander Graf wrote: >> >> On 02.05.2013, at 09:18, Gleb Natapov wrote: >> >>> On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote: On 27.04.2013, at 02:53, Scott Wood wrote: >>

Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-05-02 Thread Gleb Natapov
On Thu, May 02, 2013 at 12:53:44PM +0200, Alexander Graf wrote: > > On 02.05.2013, at 09:18, Gleb Natapov wrote: > > > On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote: > >> > >> On 27.04.2013, at 02:53, Scott Wood wrote: > >> > >>> Nobody is actually calling these functions with

Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-05-02 Thread Alexander Graf
On 02.05.2013, at 09:18, Gleb Natapov wrote: > On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote: >> >> On 27.04.2013, at 02:53, Scott Wood wrote: >> >>> Nobody is actually calling these functions with slots_lock held. >>> The srcu read lock, OTOH, is required. >>> >>> Signed-off-

Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-05-02 Thread Gleb Natapov
On Thu, May 02, 2013 at 01:24:15AM +0200, Alexander Graf wrote: > > On 27.04.2013, at 02:53, Scott Wood wrote: > > > Nobody is actually calling these functions with slots_lock held. > > The srcu read lock, OTOH, is required. > > > > Signed-off-by: Scott Wood > > Marcelo, could you please ack?

Re: [PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-05-01 Thread Alexander Graf
On 27.04.2013, at 02:53, Scott Wood wrote: > Nobody is actually calling these functions with slots_lock held. > The srcu read lock, OTOH, is required. > > Signed-off-by: Scott Wood Marcelo, could you please ack? Alex > --- > virt/kvm/kvm_main.c |4 ++-- > 1 file changed, 2 insertions(+),

[PATCH 3/3] kvm: Fix obsolete comment about locking for kvm_io_bus_read/write

2013-04-26 Thread Scott Wood
Nobody is actually calling these functions with slots_lock held. The srcu read lock, OTOH, is required. Signed-off-by: Scott Wood --- virt/kvm/kvm_main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 5da9f02..54a14fa 10