Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-25 Thread Michael S. Tsirkin
On Mon, Jun 25, 2012 at 10:17:14AM -0600, Alex Williamson wrote: > On Mon, 2012-06-25 at 02:02 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 24, 2012 at 03:59:27PM -0600, Alex Williamson wrote: > > > On Sun, 2012-06-24 at 18:49 +0300, Michael S. Tsirkin wrote: > > > > On Sun, Jun 24, 2012 at 09:

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-25 Thread Alex Williamson
On Sun, 2012-06-24 at 09:18 -0600, Alex Williamson wrote: > On Sun, 2012-06-24 at 13:29 +0300, Avi Kivity wrote: > > On 06/23/2012 01:16 AM, Alex Williamson wrote: > > > KVM_IRQFD currently only supports edge triggered interrupts, > > > asserting then immediately deasserting an interrupt. There ar

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-25 Thread Alex Williamson
On Mon, 2012-06-25 at 02:02 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 24, 2012 at 03:59:27PM -0600, Alex Williamson wrote: > > On Sun, 2012-06-24 at 18:49 +0300, Michael S. Tsirkin wrote: > > > On Sun, Jun 24, 2012 at 09:18:38AM -0600, Alex Williamson wrote: > > > > > > @@ -242,7 +299,8 @@ kvm

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-24 Thread Michael S. Tsirkin
On Sun, Jun 24, 2012 at 03:59:27PM -0600, Alex Williamson wrote: > On Sun, 2012-06-24 at 18:49 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 24, 2012 at 09:18:38AM -0600, Alex Williamson wrote: > > > > > @@ -242,7 +299,8 @@ kvm_irqfd_assign(struct kvm *kvm, struct > > > > > kvm_irqfd *args) > >

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-24 Thread Alex Williamson
On Sun, 2012-06-24 at 18:49 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 24, 2012 at 09:18:38AM -0600, Alex Williamson wrote: > > > > @@ -242,7 +299,8 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd > > > > *args) > > > > > > > > ret = 0; > > > > list_for_each_entry(tmp,

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-24 Thread Alex Williamson
On Sun, 2012-06-24 at 18:45 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 24, 2012 at 08:50:56AM -0600, Alex Williamson wrote: > > On Sun, 2012-06-24 at 11:28 +0300, Michael S. Tsirkin wrote: > > > On Fri, Jun 22, 2012 at 04:16:17PM -0600, Alex Williamson wrote: > > > > diff --git a/include/linux/

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-24 Thread Michael S. Tsirkin
On Sun, Jun 24, 2012 at 09:18:38AM -0600, Alex Williamson wrote: > > > @@ -242,7 +299,8 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd > > > *args) > > > > > > ret = 0; > > > list_for_each_entry(tmp, &kvm->irqfds.items, list) { > > > - if (irqfd->eventfd != tmp->eventfd) > > >

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-24 Thread Michael S. Tsirkin
On Sun, Jun 24, 2012 at 08:50:56AM -0600, Alex Williamson wrote: > On Sun, 2012-06-24 at 11:28 +0300, Michael S. Tsirkin wrote: > > On Fri, Jun 22, 2012 at 04:16:17PM -0600, Alex Williamson wrote: > > > diff --git a/include/linux/kvm.h b/include/linux/kvm.h > > > index 2ce09aa..a916186 100644 > > >

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-24 Thread Alex Williamson
On Sun, 2012-06-24 at 13:29 +0300, Avi Kivity wrote: > On 06/23/2012 01:16 AM, Alex Williamson wrote: > > KVM_IRQFD currently only supports edge triggered interrupts, > > asserting then immediately deasserting an interrupt. There are a > > couple ways we can emulate level triggered interrupts usin

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-24 Thread Alex Williamson
On Sun, 2012-06-24 at 11:28 +0300, Michael S. Tsirkin wrote: > On Fri, Jun 22, 2012 at 04:16:17PM -0600, Alex Williamson wrote: > > diff --git a/include/linux/kvm.h b/include/linux/kvm.h > > index 2ce09aa..a916186 100644 > > --- a/include/linux/kvm.h > > +++ b/include/linux/kvm.h > > @@ -618,6 +618

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-24 Thread Avi Kivity
On 06/23/2012 01:16 AM, Alex Williamson wrote: > KVM_IRQFD currently only supports edge triggered interrupts, > asserting then immediately deasserting an interrupt. There are a > couple ways we can emulate level triggered interrupts using > discrete events depending on the usage model we expect fr

Re: [PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-24 Thread Michael S. Tsirkin
On Fri, Jun 22, 2012 at 04:16:17PM -0600, Alex Williamson wrote: > diff --git a/include/linux/kvm.h b/include/linux/kvm.h > index 2ce09aa..a916186 100644 > --- a/include/linux/kvm.h > +++ b/include/linux/kvm.h > @@ -618,6 +618,7 @@ struct kvm_ppc_smmu_info { > #define KVM_CAP_PPC_GET_SMMU_INFO 78

[PATCH 3/4] kvm: Extend irqfd to support level interrupts

2012-06-22 Thread Alex Williamson
KVM_IRQFD currently only supports edge triggered interrupts, asserting then immediately deasserting an interrupt. There are a couple ways we can emulate level triggered interrupts using discrete events depending on the usage model we expect from drivers. This patch implements a level emulation mod