Re: [PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst

2009-09-06 Thread Avi Kivity
On 09/03/2009 05:25 PM, Orit Wasserman wrote: + /* +* Level 2 state : includes vmcs,registers and +* a copy of vmcs12 for vmread/vmwrite +*/ + struct level_state *l2_state; + + /* Level 1 state for switching to level 2 and back */ + struct level_state *l1_state;

Re: [PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst

2009-09-06 Thread Orit Wasserman
...@ibmil Date: 06/09/2009 12:25 Subject: Re: [PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst On 09/03/2009 05:25 PM, Orit Wasserman wrote: + /* +* Level 2 state : includes vmcs,registers and +* a copy of vmcs12 for vmread/vmwrite +*/ + struct

Re: [PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst

2009-09-06 Thread Avi Kivity
On 09/06/2009 04:36 PM, Orit Wasserman wrote: When we support multiple nested guests, we'll run into a problem of where to store shadow_vmcs. I see these options: - maintain a cache of limited size of shadow_vmcs; when evicting, copy the shadow_vmcs into the guest's vmptr] - always put

Re: [PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst

2009-09-06 Thread Orit Wasserman
...@ibmil Date: 06/09/2009 16:53 Subject: Re: [PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst On 09/06/2009 04:36 PM, Orit Wasserman wrote: When we support multiple nested guests, we'll run into a problem of where to store shadow_vmcs. I see these options: - maintain

Re: [PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst

2009-09-06 Thread Avi Kivity
On 09/06/2009 07:55 PM, Orit Wasserman wrote: Note other things like the msr bitmaps may need write protection, otherwise you have to re-merge the bitmap on every guest entry, which can be very slow. So we may be forced to add write protection anyway. We will also need to write protected

Re: [PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst

2009-09-03 Thread Orit Wasserman
...@us.ibm.com Date: 02/09/2009 23:04 Subject: Re: [PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst On 09/02/2009 06:38 PM, or...@il.ibm.com wrote: +struct __attribute__ ((__packed__)) level_state { + struct shadow_vmcs *shadow_vmcs; + + u16 vpid; + u64 shadow_efer

[PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst

2009-09-02 Thread oritw
From: Orit Wasserman or...@il.ibm.com --- arch/x86/kvm/vmx.c | 533 +++- 1 files changed, 523 insertions(+), 10 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 2b1fc3b..5ab07a0 100644 --- a/arch/x86/kvm/vmx.c +++

Re: [PATCH 3/6] Nested VMX patch 3 implements vmptrld and vmptrst

2009-09-02 Thread Avi Kivity
On 09/02/2009 06:38 PM, or...@il.ibm.com wrote: +struct __attribute__ ((__packed__)) level_state { + struct shadow_vmcs *shadow_vmcs; + + u16 vpid; + u64 shadow_efer; + unsigned long cr2; + unsigned long cr3; + unsigned long cr4; + unsigned long cr8; + +