Re: [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-09 Thread Jan Kiszka
On 2012-02-09 18:20, Paolo Bonzini wrote: > On 02/09/2012 05:32 PM, Jan Kiszka wrote: >> > I mean just check kpcr.self. >> >> Yes, clear, but that means that Windows must have initialized FS.base to >> point to the KPCR also in UP mode. Is that really the case? E.g. when >> ACPI is off?! I wonder

Re: [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-09 Thread Jan Kiszka
On 2012-02-09 17:47, Avi Kivity wrote: > On 02/09/2012 06:32 PM, Jan Kiszka wrote: We need to patch the causing instruction, so we have to know where it starts. Or what do you mean? >>> >>> Just don't deal with this at all, no one runs on kernels without kernel >>> irqchip. >> >> Not

Re: [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-09 Thread Paolo Bonzini
On 02/09/2012 05:32 PM, Jan Kiszka wrote: > I mean just check kpcr.self. Yes, clear, but that means that Windows must have initialized FS.base to point to the KPCR also in UP mode. Is that really the case? E.g. when ACPI is off?! I wonder if that explains the reported bug of qemu-kvm with -no-a

Re: [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-09 Thread Avi Kivity
On 02/09/2012 06:32 PM, Jan Kiszka wrote: > >> > >> We need to patch the causing instruction, so we have to know where it > >> starts. Or what do you mean? > > > > Just don't deal with this at all, no one runs on kernels without kernel > > irqchip. > > Not true for upstream, It was introduced in

Re: [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-09 Thread Jan Kiszka
On 2012-02-09 17:00, Avi Kivity wrote: > On 02/09/2012 05:39 PM, Jan Kiszka wrote: >> On 2012-02-09 16:18, Avi Kivity wrote: >>> On 02/05/2012 02:39 PM, Jan Kiszka wrote: From: Jan Kiszka This enables acceleration for MMIO-based TPR registers accesses of 32-bit Windows guest sy

Re: [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-09 Thread Avi Kivity
On 02/09/2012 05:39 PM, Jan Kiszka wrote: > On 2012-02-09 16:18, Avi Kivity wrote: > > On 02/05/2012 02:39 PM, Jan Kiszka wrote: > >> From: Jan Kiszka > >> > >> This enables acceleration for MMIO-based TPR registers accesses of > >> 32-bit Windows guest systems. It is mostly useful with KVM enable

Re: [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-09 Thread Jan Kiszka
On 2012-02-09 16:18, Avi Kivity wrote: > On 02/05/2012 02:39 PM, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This enables acceleration for MMIO-based TPR registers accesses of >> 32-bit Windows guest systems. It is mostly useful with KVM enabled, >> either on older Intel CPUs (without flexpriority

Re: [PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-09 Thread Avi Kivity
On 02/05/2012 02:39 PM, Jan Kiszka wrote: > From: Jan Kiszka > > This enables acceleration for MMIO-based TPR registers accesses of > 32-bit Windows guest systems. It is mostly useful with KVM enabled, > either on older Intel CPUs (without flexpriority feature, can also be > manually disabled for

[PATCH 3/6] kvmvapic: Introduce TPR access optimization for Windows guests

2012-02-05 Thread Jan Kiszka
From: Jan Kiszka This enables acceleration for MMIO-based TPR registers accesses of 32-bit Windows guest systems. It is mostly useful with KVM enabled, either on older Intel CPUs (without flexpriority feature, can also be manually disabled for testing) or any current AMD processor. The approach