[PATCH 4/4] KVM: x86 emulator: fix REPZ/REPNZ termination condition

2010-08-17 Thread Avi Kivity
EFLAGS.ZF needs to be checked after each iteration, not before. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 42 +++--- 1 files changed, 23 insertions(+), 19 deletions(-) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 0c0ada9..

Re: [PATCH 4/4] KVM: x86 emulator: fix REPZ/REPNZ termination condition

2010-08-17 Thread Gleb Natapov
On Tue, Aug 17, 2010 at 11:26:43AM +0300, Avi Kivity wrote: > EFLAGS.ZF needs to be checked after each iteration, not before. > > Signed-off-by: Avi Kivity > --- > arch/x86/kvm/emulate.c | 42 +++--- > 1 files changed, 23 insertions(+), 19 deletions(-) > >

Re: [PATCH 4/4] KVM: x86 emulator: fix REPZ/REPNZ termination condition

2010-08-17 Thread Avi Kivity
On 08/17/2010 12:13 PM, Gleb Natapov wrote: On Tue, Aug 17, 2010 at 11:26:43AM +0300, Avi Kivity wrote: EFLAGS.ZF needs to be checked after each iteration, not before. Signed-off-by: Avi Kivity --- arch/x86/kvm/emulate.c | 42 +++--- 1 files changed, 23

Re: [PATCH 4/4] KVM: x86 emulator: fix REPZ/REPNZ termination condition

2010-08-17 Thread Gleb Natapov
On Tue, Aug 17, 2010 at 12:20:34PM +0300, Avi Kivity wrote: > On 08/17/2010 12:13 PM, Gleb Natapov wrote: > >On Tue, Aug 17, 2010 at 11:26:43AM +0300, Avi Kivity wrote: > >>EFLAGS.ZF needs to be checked after each iteration, not before. > >> > >>Signed-off-by: Avi Kivity > >>--- > >> arch/x86/kvm

Re: [PATCH 4/4] KVM: x86 emulator: fix REPZ/REPNZ termination condition

2010-08-17 Thread Avi Kivity
On 08/17/2010 12:27 PM, Gleb Natapov wrote: On Tue, Aug 17, 2010 at 12:20:34PM +0300, Avi Kivity wrote: On 08/17/2010 12:13 PM, Gleb Natapov wrote: On Tue, Aug 17, 2010 at 11:26:43AM +0300, Avi Kivity wrote: EFLAGS.ZF needs to be checked after each iteration, not before. Signed-off-by: Avi