Re: [PATCH 4/9] Implement hsave v5

2008-10-30 Thread Anthony Liguori
Alexander Graf wrote: Implement the hsave MSR, that gives the VCPU a GPA to save the old guest state in. v2 allows userspace to save/restore hsave v4 dummys out the hsave MSR, so we use a host page Signed-off-by: Alexander Graf [EMAIL PROTECTED] --- arch/x86/kvm/kvm_svm.h |1 +

Re: [PATCH 4/9] Implement hsave v5

2008-10-30 Thread Alexander Graf
On 30.10.2008, at 19:04, Anthony Liguori wrote: Alexander Graf wrote: Implement the hsave MSR, that gives the VCPU a GPA to save the old guest state in. v2 allows userspace to save/restore hsave v4 dummys out the hsave MSR, so we use a host page snip

Re: [PATCH 4/9] Implement hsave v5

2008-10-30 Thread Anthony Liguori
Alexander Graf wrote: On 30.10.2008, at 19:04, Anthony Liguori wrote: kmem_cache_free(kvm_vcpu_cache, svm); } @@ -1376,6 +1383,9 @@ static int svm_get_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 *data) case MSR_IA32_LASTINTTOIP: *data = svm-vmcb-save.last_excp_to;

Re: [PATCH 4/9] Implement hsave v5

2008-10-30 Thread Avi Kivity
Alexander Graf wrote: I don't see any benefit from actually exporting that MSR atm. KVM does never read it and it'd just add additional overhead on every userspace transition, as it'd need to be synced every time. We only sync MSRs on save/restore. -- I have a truly marvellous patch that

Re: [PATCH 4/9] Implement hsave v5

2008-10-30 Thread Alexander Graf
On 30.10.2008, at 20:29, Avi Kivity wrote: Alexander Graf wrote: I don't see any benefit from actually exporting that MSR atm. KVM does never read it and it'd just add additional overhead on every userspace transition, as it'd need to be synced every time. We only sync MSRs on

[PATCH 4/9] Implement hsave v5

2008-10-20 Thread Alexander Graf
Implement the hsave MSR, that gives the VCPU a GPA to save the old guest state in. v2 allows userspace to save/restore hsave v4 dummys out the hsave MSR, so we use a host page Signed-off-by: Alexander Graf [EMAIL PROTECTED] --- arch/x86/kvm/kvm_svm.h |1 + arch/x86/kvm/svm.c | 12