Re: [PATCH 5/5] HPET interaction with in-kernel PIT (v6)

2009-06-14 Thread Avi Kivity
Beth Kon wrote: Signed-off-by: Beth Kon e...@us.ibm.com Please write a few words on what this patch does and why. --- arch/x86/include/asm/kvm.h |1 + arch/x86/kvm/i8254.c | 24 +++- arch/x86/kvm/i8254.h |3 ++- arch/x86/kvm/x86.c |5

Re: [PATCH 5/5] HPET interaction with in-kernel PIT (v6)

2009-06-14 Thread Jan Kiszka
Avi Kivity wrote: Beth Kon wrote: Signed-off-by: Beth Kon e...@us.ibm.com Please write a few words on what this patch does and why. --- arch/x86/include/asm/kvm.h |1 + arch/x86/kvm/i8254.c | 24 +++- arch/x86/kvm/i8254.h |3 ++-

Re: [PATCH 5/5] HPET interaction with in-kernel PIT (v6)

2009-06-14 Thread Jan Kiszka
Avi Kivity wrote: Jan Kiszka wrote: struct kvm_pit_state { struct kvm_pit_channel_state channels[3]; +u8 hpet_legacy_mode; }; This changes the ABI, breaking older binaries running on newer kernels, or newer binaries running on older kernels. As we have

Re: [PATCH 5/5] HPET interaction with in-kernel PIT (v6)

2009-06-14 Thread Avi Kivity
Jan Kiszka wrote: Unfortunate. But on the one hand, nothing technically prevents defining the IOCTL base on existing kvm_pit_state, but passing down extended kvm_pit_state2 if that negotiation took place. On the other hand, we are not yet running out of IOCTL numbers... Right, and we are

Re: [PATCH 5/5] HPET interaction with in-kernel PIT (v6)

2009-06-14 Thread Avi Kivity
Jan Kiszka wrote: struct kvm_pit_state { struct kvm_pit_channel_state channels[3]; +u8 hpet_legacy_mode; }; This changes the ABI, breaking older binaries running on newer kernels, or newer binaries running on older kernels. As we have KVM_CREATE_PIT2 now, which

[PATCH 5/5] HPET interaction with in-kernel PIT (v6)

2009-06-11 Thread Beth Kon
Signed-off-by: Beth Kon e...@us.ibm.com --- arch/x86/include/asm/kvm.h |1 + arch/x86/kvm/i8254.c | 24 +++- arch/x86/kvm/i8254.h |3 ++- arch/x86/kvm/x86.c |5 - 4 files changed, 26 insertions(+), 7 deletions(-) diff --git