Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Paolo Bonzini
On 30/03/2015 21:31, Nadav Amit wrote: > > Because QEMU support for INIT is incomplete, so the tests would fail > > ("Uh, hard reset!"). IIRC sending init to BSP with APIC_DEST_SELF is > > also not supported by actual hardware (or at least not supported > > "officially") so that test would also

Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Nadav Amit
Paolo Bonzini wrote: > On 30/03/2015 16:40, Nadav Amit wrote: >> Paolo, >> >> It appears you are right and I have not tested 4 and 5 well enough. I’ll >> repost them (the others were tested presumably well enough). >> >> Two short questions: >> Can I use init.c in the kvm-unit-tests ? >> Why i

Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Paolo Bonzini
On 30/03/2015 16:40, Nadav Amit wrote: > Paolo, > > It appears you are right and I have not tested 4 and 5 well enough. I’ll > repost them (the others were tested presumably well enough). > > Two short questions: > Can I use init.c in the kvm-unit-tests ? > Why is it disabled? Because QEMU su

Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Nadav Amit
Paolo, It appears you are right and I have not tested 4 and 5 well enough. I’ll repost them (the others were tested presumably well enough). Two short questions: Can I use init.c in the kvm-unit-tests ? Why is it disabled? Nadav Paolo Bonzini wrote: > > > On 30/03/2015 14:39, Nadav Amit w

Re: [PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Paolo Bonzini
On 30/03/2015 14:39, Nadav Amit wrote: > After reset, the CPU can change the BSP, which will be used upon INIT. Reset > should return the BSP which QEMU asked for, and therefore handled accordingly. > > To quote: "If the MP protocol has completed and a BSP is chosen, subsequent > INITs (either

[PATCH 5/5] KVM: x86: BSP in MSR_IA32_APICBASE is writable

2015-03-30 Thread Nadav Amit
After reset, the CPU can change the BSP, which will be used upon INIT. Reset should return the BSP which QEMU asked for, and therefore handled accordingly. To quote: "If the MP protocol has completed and a BSP is chosen, subsequent INITs (either to a specific processor or system wide) do not caus