Re: [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5

2008-10-30 Thread Anthony Liguori
Alexander Graf wrote: This implements the VMLOAD and VMSAVE instructions, that usually surround the VMRUN instructions. Both instructions load / restore the same elements, so we only need to implement them once. v2 fixes CPL checking and replaces memcpy by assignments v3 makes use of the new

Re: [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5

2008-10-30 Thread Alexander Graf
On 30.10.2008, at 19:06, Anthony Liguori wrote: Alexander Graf wrote: This implements the VMLOAD and VMSAVE instructions, that usually surround the VMRUN instructions. Both instructions load / restore the same elements, so we only need to implement them once. v2 fixes CPL checking and

Re: [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5

2008-10-30 Thread Anthony Liguori
Alexander Graf wrote: On 30.10.2008, at 19:06, Anthony Liguori wrote: Alexander Graf wrote: This implements the VMLOAD and VMSAVE instructions, that usually surround the VMRUN instructions. Both instructions load / restore the same elements, so we only need to implement them once. v2

Re: [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5

2008-10-30 Thread Alexander Graf
On 30.10.2008, at 20:14, Anthony Liguori wrote: Alexander Graf wrote: On 30.10.2008, at 19:06, Anthony Liguori wrote: Alexander Graf wrote: This implements the VMLOAD and VMSAVE instructions, that usually surround the VMRUN instructions. Both instructions load / restore the same

Re: [PATCH 5/9] Add VMLOAD and VMSAVE handlers v5

2008-10-30 Thread Anthony Liguori
Alexander Graf wrote: On 30.10.2008, at 20:14, Anthony Liguori wrote: I don't see this improving code readability, but maybe that again is just personal preference. Is this a real problem, or just again a different esthetic view? I'm not wildy opposed to your implementation so I'm

[PATCH 5/9] Add VMLOAD and VMSAVE handlers v5

2008-10-20 Thread Alexander Graf
This implements the VMLOAD and VMSAVE instructions, that usually surround the VMRUN instructions. Both instructions load / restore the same elements, so we only need to implement them once. v2 fixes CPL checking and replaces memcpy by assignments v3 makes use of the new permission checking