On 05/02/2015 07:23, Kai Huang wrote:
>>>
>>> +/* PML is enabled/disabled in creating/destorying vcpu */
>>> +exec_control &= ~SECONDARY_EXEC_ENABLE_PML;
>> What is the harm of enabling it here?
>>
>> (SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES seems similar and does it.)
>
> Because the PML
On 02/05/2015 11:04 PM, Radim Krčmář wrote:
2015-02-05 14:23+0800, Kai Huang:
On 02/03/2015 11:18 PM, Radim Krčmář wrote:
You have it protected by CONFIG_X86_64, but use it unconditionally.
Thanks for catching. This has been fixed by another patch, and the fix has
also been merged by Paolo.
On 02/05/2015 11:04 PM, Radim Krčmář wrote:
2015-02-05 14:23+0800, Kai Huang:
On 02/03/2015 11:18 PM, Radim Krčmář wrote:
You have it protected by CONFIG_X86_64, but use it unconditionally.
Thanks for catching. This has been fixed by another patch, and the fix has
also been merged by Paolo.
2015-02-05 14:23+0800, Kai Huang:
> On 02/03/2015 11:18 PM, Radim Krčmář wrote:
> >You have it protected by CONFIG_X86_64, but use it unconditionally.
> Thanks for catching. This has been fixed by another patch, and the fix has
> also been merged by Paolo.
(And I haven't noticed the followup eithe
On 02/03/2015 11:18 PM, Radim Krčmář wrote:
2015-01-28 10:54+0800, Kai Huang:
This patch adds PML support in VMX. A new module parameter 'enable_pml' is added
(+module_param_named(pml, enable_pml, bool, S_IRUGO);)
to allow user to enable/disable it manually.
Signed-off-by: Kai Huang
---
di
2015-02-03 16:39+0100, Paolo Bonzini:
>
>
> On 03/02/2015 16:18, Radim Krčmář wrote:
> > (I see the same code in handle_ept_violation(), but wasn't that needed
> > just because of a hardware error?)
>
> That was how I read it initially, but actually that means: "this
> statement could be broken
On 03/02/2015 16:18, Radim Krčmář wrote:
> (I see the same code in handle_ept_violation(), but wasn't that needed
> just because of a hardware error?)
That was how I read it initially, but actually that means: "this
statement could be broken if the processor has that erratum".
>> +static void
2015-01-28 10:54+0800, Kai Huang:
> This patch adds PML support in VMX. A new module parameter 'enable_pml' is
> added
(+module_param_named(pml, enable_pml, bool, S_IRUGO);)
> to allow user to enable/disable it manually.
>
> Signed-off-by: Kai Huang
> ---
> diff --git a/arch/x86/kvm/trace.h b/
This patch adds PML support in VMX. A new module parameter 'enable_pml' is added
to allow user to enable/disable it manually.
Signed-off-by: Kai Huang
---
arch/x86/include/asm/vmx.h | 4 +
arch/x86/include/uapi/asm/vmx.h | 1 +
arch/x86/kvm/trace.h| 18
arch/x86/kvm/vm
