[PATCH 7/8] KVM: Optimize kvm_read_cr[04]_bits()

2010-01-21 Thread Avi Kivity
'mask' is always a constant, so we can check whether it includes a bit that might be owned by the guest very cheaply, and avoid the decache call. Saves a few hundred bytes of module text. Signed-off-by: Avi Kivity --- arch/x86/kvm/kvm_cache_regs.h |9 +++-- 1 files changed, 7 insertions

Re: [PATCH 7/8] KVM: Optimize kvm_read_cr[04]_bits()

2010-02-05 Thread Jan Kiszka
Avi Kivity wrote: > 'mask' is always a constant, so we can check whether it includes a bit that > might be owned by the guest very cheaply, and avoid the decache call. Saves > a few hundred bytes of module text. -no-kvm-irqchip -smp 2 is broken for my Linux guests since this commit. Their user sp

Re: [PATCH 7/8] KVM: Optimize kvm_read_cr[04]_bits()

2010-02-07 Thread Avi Kivity
On 02/05/2010 10:26 AM, Jan Kiszka wrote: Avi Kivity wrote: 'mask' is always a constant, so we can check whether it includes a bit that might be owned by the guest very cheaply, and avoid the decache call. Saves a few hundred bytes of module text. -no-kvm-irqchip -smp 2 is broken for

Re: [PATCH 7/8] KVM: Optimize kvm_read_cr[04]_bits()

2010-02-07 Thread Jan Kiszka
Avi Kivity wrote: > On 02/05/2010 10:26 AM, Jan Kiszka wrote: >> Avi Kivity wrote: >> >>> 'mask' is always a constant, so we can check whether it includes a >>> bit that >>> might be owned by the guest very cheaply, and avoid the decache >>> call. Saves >>> a few hundred bytes of module text. >

Re: [PATCH 7/8] KVM: Optimize kvm_read_cr[04]_bits()

2010-02-07 Thread Avi Kivity
On 02/07/2010 02:33 PM, Jan Kiszka wrote: Avi Kivity wrote: On 02/05/2010 10:26 AM, Jan Kiszka wrote: Avi Kivity wrote: 'mask' is always a constant, so we can check whether it includes a bit that might be owned by the guest very cheaply, and avoid the decache call. Saves a

Re: [PATCH 7/8] KVM: Optimize kvm_read_cr[04]_bits()

2010-02-07 Thread Jan Kiszka
Avi Kivity wrote: > On 02/07/2010 02:33 PM, Jan Kiszka wrote: >> Avi Kivity wrote: >> >>> On 02/05/2010 10:26 AM, Jan Kiszka wrote: >>> Avi Kivity wrote: > 'mask' is always a constant, so we can check whether it includes a > bit that > might be owned by the