Re: [PATCH 7/9] Add VMRUN handler v3

2008-09-27 Thread Avi Kivity
[EMAIL PROTECTED] wrote: Copying data in memory is always expensive because the accesses may miss in the caches and data must be fetched from memory. As far as I know this can be around 150 cycles per cache line. When the copy is sequential, the processor will prefetch the data ahead of tim

Re: [PATCH 7/9] Add VMRUN handler v3

2008-09-27 Thread Avi Kivity
Alexander Graf wrote: Is copying one page really that expensive? Is there any accelerated function available for that that copies it with SSE or so? :-) 'rep movs' is supposed to be accelerated, doing cacheline-by-cacheline copies (at least on Intel). In any case the kernel memcpy() shou

Re: [PATCH 7/9] Add VMRUN handler v3

2008-09-25 Thread [EMAIL PROTECTED]
On Thu, Sep 25, 2008 at 10:00:17PM +0200, Alexander Graf wrote: > > On 25.09.2008, at 19:37, Joerg Roedel wrote: > > >On Thu, Sep 25, 2008 at 07:32:55PM +0200, Alexander Graf wrote: > >>>This is a big security hole. With this we give the guest access to > >>>its > >>>own VMCB. The guest can tak

Re: [PATCH 7/9] Add VMRUN handler v3

2008-09-25 Thread Alexander Graf
On 25.09.2008, at 19:37, Joerg Roedel wrote: On Thu, Sep 25, 2008 at 07:32:55PM +0200, Alexander Graf wrote: This is a big security hole. With this we give the guest access to its own VMCB. The guest can take over or crash the whole host machine by rewriting its VMCB. We should be more selec

Re: [PATCH 7/9] Add VMRUN handler v3

2008-09-25 Thread Joerg Roedel
On Thu, Sep 25, 2008 at 07:32:55PM +0200, Alexander Graf wrote: > >This is a big security hole. With this we give the guest access to its > >own VMCB. The guest can take over or crash the whole host machine by > >rewriting its VMCB. We should be more selective what we save in the > >hsave area. >

Re: [PATCH 7/9] Add VMRUN handler v3

2008-09-25 Thread Alexander Graf
Am 19.09.2008 um 17:59 schrieb Joerg Roedel <[EMAIL PROTECTED]>: On Wed, Sep 17, 2008 at 03:41:24PM +0200, Alexander Graf wrote: This patch implements VMRUN. VMRUN enters a virtual CPU and runs that in the same context as the normal guest CPU would run. So basically it is implemented the sa

Re: [PATCH 7/9] Add VMRUN handler v3

2008-09-19 Thread Joerg Roedel
On Wed, Sep 17, 2008 at 03:41:24PM +0200, Alexander Graf wrote: > This patch implements VMRUN. VMRUN enters a virtual CPU and runs that > in the same context as the normal guest CPU would run. > So basically it is implemented the same way, a normal CPU would do it. > > We also prepare all intercep

[PATCH 7/9] Add VMRUN handler v3

2008-09-17 Thread Alexander Graf
This patch implements VMRUN. VMRUN enters a virtual CPU and runs that in the same context as the normal guest CPU would run. So basically it is implemented the same way, a normal CPU would do it. We also prepare all intercepts that get OR'ed with the original intercepts, as we do not allow a level