Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2009-04-17 Thread Dmitry Eremin-Solenikov
Glauber Costa wrote: > Remove explicit calls to mmio coalescing. Rather, include it in the > registration functions. > OK. On real SVM HW this seems to work. However now i'm stumbled upon another problem wrt. NMI. See another mail. -- With best wishes Dmitry se -- To unsubscribe from this li

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-25 Thread Glauber Costa
On Thu, Sep 25, 2008 at 10:08:53AM +0300, Avi Kivity wrote: > Glauber Costa wrote: > > > > Any ideas about what's up for the other hypervisors that may (we hope) be > > integrated > > in the future? Xen? > > > > Xen should benefit even more (much more). IIRC Windows wouldn't boot > since it w

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-25 Thread Avi Kivity
Glauber Costa wrote: > > Any ideas about what's up for the other hypervisors that may (we hope) be > integrated > in the future? Xen? > Xen should benefit even more (much more). IIRC Windows wouldn't boot since it was spending all its time context switching when the splash screen with its KIT

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-24 Thread Glauber Costa
On Wed, Sep 24, 2008 at 02:10:26PM +0300, Avi Kivity wrote: > Glauber Costa wrote: >>> You can't coalesce the registers which trigger device action. You'll >>> destroy latency and/or functionality. >>> >> >> which kills the goal of getting rid of explicit kvm code. >> >> > > It's a fact

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-24 Thread Avi Kivity
Glauber Costa wrote: You can't coalesce the registers which trigger device action. You'll destroy latency and/or functionality. which kills the goal of getting rid of explicit kvm code. It's a fact that coalescing helps kvm but not qemu. So maybe the solution here is to add calls

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-23 Thread Glauber Costa
On Tue, Sep 23, 2008 at 10:29:48AM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> On Sat, Sep 20, 2008 at 11:39:44AM -0700, Avi Kivity wrote: >> >>> Glauber Costa wrote: >>> Remove explicit calls to mmio coalescing. Rather, include it in the registration functions. i

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-23 Thread Avi Kivity
Glauber Costa wrote: On Sat, Sep 20, 2008 at 11:39:44AM -0700, Avi Kivity wrote: Glauber Costa wrote: Remove explicit calls to mmio coalescing. Rather, include it in the registration functions. index 5ae3960..2d97b34 100644 --- a/qemu/hw/e1000.c +++ b/qemu/hw/e1000.c @@ -942,18 +942,6

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-22 Thread Glauber Costa
On Sat, Sep 20, 2008 at 11:39:44AM -0700, Avi Kivity wrote: > Glauber Costa wrote: >> Remove explicit calls to mmio coalescing. Rather, >> include it in the registration functions. >> >> index 5ae3960..2d97b34 100644 >> --- a/qemu/hw/e1000.c >> +++ b/qemu/hw/e1000.c >> @@ -942,18 +942,6 @@ e1000_mm

Re: [PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-20 Thread Avi Kivity
Glauber Costa wrote: Remove explicit calls to mmio coalescing. Rather, include it in the registration functions. index 5ae3960..2d97b34 100644 --- a/qemu/hw/e1000.c +++ b/qemu/hw/e1000.c @@ -942,18 +942,6 @@ e1000_mmio_map(PCIDevice *pci_dev, int region_num, d->mmio_base = addr; cpu

[PATCH 8/9] coalesce mmio regions with an explicit call

2008-09-19 Thread Glauber Costa
Remove explicit calls to mmio coalescing. Rather, include it in the registration functions. Signed-off-by: Glauber Costa <[EMAIL PROTECTED]> --- qemu/hw/cirrus_vga.c |2 -- qemu/hw/e1000.c | 12 qemu/hw/pci.c|3 --- qemu/hw/vga.c|4 qemu/qemu-k