Re: [SeaBIOS] [PATCH RFC] seabios: add OSHP method stub

2012-02-29 Thread Gerd Hoffmann
diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl index 442e7a8..3f50169 100644 --- a/src/ssdt-pcihp.dsl +++ b/src/ssdt-pcihp.dsl @@ -24,6 +24,7 @@ DefinitionBlock (ssdt-pcihp.aml, SSDT, 0x01, BXPC, BXSSDTPCIHP, 0x1) ACPI_EXTRACT_METHOD_STRING aml_ej0_name \

Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub

2012-02-14 Thread Paul Brook
In a nutshell, I don't know what a SHPC is (nor OSHP), so I'm looking for an additional Ack. No problem, I'll get an Ack :) Meanwhile - here's a summary, as far as I understand it. Originally PCI SIG only defined the electrical and mechanical requirements from hotplug, no standard

Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub

2012-02-14 Thread Michael S. Tsirkin
On Tue, Feb 14, 2012 at 12:49:08PM +, Paul Brook wrote: In a nutshell, I don't know what a SHPC is (nor OSHP), so I'm looking for an additional Ack. No problem, I'll get an Ack :) Meanwhile - here's a summary, as far as I understand it. Originally PCI SIG only defined the

Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub

2012-02-14 Thread Paul Brook
Now an OS can have a standard driver and use it to activate hotplug functionality. This is OS hotplug (OSHP). So presumably this will work on targets that don't have ACPI? Assuming a competent guest OS of course. Have you tested this? This being the qemu side of things? I run

Re: [Qemu-devel] [PATCH RFC] seabios: add OSHP method stub

2012-02-14 Thread Michael S. Tsirkin
On Tue, Feb 14, 2012 at 01:47:59PM +, Paul Brook wrote: Now an OS can have a standard driver and use it to activate hotplug functionality. This is OS hotplug (OSHP). So presumably this will work on targets that don't have ACPI? Assuming a competent guest OS of course. Have

[PATCH RFC] seabios: add OSHP method stub

2012-02-13 Thread Michael S. Tsirkin
To allow guests to load the native SHPC driver for a bridge, we must declare an OSHP method for the appropriate device which lets the OS take control of the SHPC. As we don't access SHPC at the moment, we don't need to do anything - just report success. Signed-off-by: Michael S. Tsirkin

Re: [PATCH RFC] seabios: add OSHP method stub

2012-02-13 Thread Kevin O'Connor
On Mon, Feb 13, 2012 at 11:33:08AM +0200, Michael S. Tsirkin wrote: To allow guests to load the native SHPC driver for a bridge, we must declare an OSHP method for the appropriate device which lets the OS take control of the SHPC. As we don't access SHPC at the moment, we don't need to do

Re: [PATCH RFC] seabios: add OSHP method stub

2012-02-13 Thread Kevin O'Connor
On Tue, Feb 14, 2012 at 02:43:45AM +0200, Michael S. Tsirkin wrote: On Mon, Feb 13, 2012 at 07:34:55PM -0500, Kevin O'Connor wrote: On Mon, Feb 13, 2012 at 11:33:08AM +0200, Michael S. Tsirkin wrote: To allow guests to load the native SHPC driver for a bridge, we must declare an OSHP

Re: [PATCH RFC] seabios: add OSHP method stub

2012-02-13 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 07:48:37PM -0500, Kevin O'Connor wrote: On Tue, Feb 14, 2012 at 02:43:45AM +0200, Michael S. Tsirkin wrote: On Mon, Feb 13, 2012 at 07:34:55PM -0500, Kevin O'Connor wrote: On Mon, Feb 13, 2012 at 11:33:08AM +0200, Michael S. Tsirkin wrote: To allow guests to load

Re: [PATCH RFC] seabios: add OSHP method stub

2012-02-13 Thread Michael S. Tsirkin
On Mon, Feb 13, 2012 at 07:34:55PM -0500, Kevin O'Connor wrote: On Mon, Feb 13, 2012 at 11:33:08AM +0200, Michael S. Tsirkin wrote: To allow guests to load the native SHPC driver for a bridge, we must declare an OSHP method for the appropriate device which lets the OS take control of the