Re: [PATCH RFC 1/5] KVM: introduce a set_bit function for bitmaps in user space

2010-04-21 Thread Avi Kivity
On 04/21/2010 07:56 AM, Fernando Luis Vázquez Cao wrote: On 04/12/2010 02:08 AM, Avi Kivity wrote: +#define __set_bit_user_asm(nr, addr, err, errret)\ +asm volatile("1:bts %1,%2\n"\ + "2:\n"\ + ".section .fix

Re: [PATCH RFC 1/5] KVM: introduce a set_bit function for bitmaps in user space

2010-04-20 Thread Fernando Luis Vázquez Cao
On 04/12/2010 02:08 AM, Avi Kivity wrote: >> +#define __set_bit_user_asm(nr, addr, err, errret)\ >> +asm volatile("1:bts %1,%2\n"\ >> + "2:\n"\ >> + ".section .fixup,\"ax\"\n"\ >> + "3:

Re: [PATCH RFC 1/5] KVM: introduce a set_bit function for bitmaps in user space

2010-04-12 Thread Avi Kivity
On 04/12/2010 04:29 AM, Takuya Yoshikawa wrote: Should be called __set_bit_user() since it is non-atomic. Actually I first named it like that and then noticed that in the uaccess' convention, __ prefix means it is "with less checking" version. On the other hand, for the bitops family, __ mea

Re: [PATCH RFC 1/5] KVM: introduce a set_bit function for bitmaps in user space

2010-04-11 Thread Takuya Yoshikawa
(2010/04/12 2:08), Avi Kivity wrote: On 04/09/2010 12:30 PM, Takuya Yoshikawa wrote: This work is initially suggested by Avi Kivity for moving the dirty bitmaps used by KVM to user space: This makes it possible to manipulate the bitmaps from qemu without copying from KVM. Note: We are now brush

Re: [PATCH RFC 1/5] KVM: introduce a set_bit function for bitmaps in user space

2010-04-11 Thread Avi Kivity
On 04/09/2010 12:30 PM, Takuya Yoshikawa wrote: This work is initially suggested by Avi Kivity for moving the dirty bitmaps used by KVM to user space: This makes it possible to manipulate the bitmaps from qemu without copying from KVM. Note: We are now brushing up this code before sending to x86

[PATCH RFC 1/5] KVM: introduce a set_bit function for bitmaps in user space

2010-04-09 Thread Takuya Yoshikawa
This work is initially suggested by Avi Kivity for moving the dirty bitmaps used by KVM to user space: This makes it possible to manipulate the bitmaps from qemu without copying from KVM. Note: We are now brushing up this code before sending to x86's maintainers. Signed-off-by: Takuya Yoshikawa