Re: [PATCH V4 1/4] kvm: factor out core eventfd assign/deassign logic

2015-09-11 Thread Jason Wang
On 09/11/2015 03:39 PM, Cornelia Huck wrote: > On Fri, 11 Sep 2015 11:17:34 +0800 > Jason Wang wrote: > >> This patch factors out core eventfd assign/deassign logic and leave >> the argument checking and bus index selection to callers. >> >> Cc: Gleb Natapov >> Cc: Paolo Bonzini >> Signed-off-

Re: [PATCH V4 1/4] kvm: factor out core eventfd assign/deassign logic

2015-09-11 Thread Paolo Bonzini
On 11/09/2015 09:39, Cornelia Huck wrote: > > +static int > > +kvm_deassign_ioeventfd_idx(struct kvm *kvm, enum kvm_bus bus_idx, > > + struct kvm_ioeventfd *args) > > While this file uses newline before function name quite often, putting > it on the same line seems more comm

Re: [PATCH V4 1/4] kvm: factor out core eventfd assign/deassign logic

2015-09-11 Thread Cornelia Huck
On Fri, 11 Sep 2015 11:17:34 +0800 Jason Wang wrote: > This patch factors out core eventfd assign/deassign logic and leave > the argument checking and bus index selection to callers. > > Cc: Gleb Natapov > Cc: Paolo Bonzini > Signed-off-by: Jason Wang > --- > virt/kvm/eventfd.c | 83 > +

[PATCH V4 1/4] kvm: factor out core eventfd assign/deassign logic

2015-09-10 Thread Jason Wang
This patch factors out core eventfd assign/deassign logic and leave the argument checking and bus index selection to callers. Cc: Gleb Natapov Cc: Paolo Bonzini Signed-off-by: Jason Wang --- virt/kvm/eventfd.c | 83 -- 1 file changed, 49 inse