Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging

2012-02-09 Thread Takuya Yoshikawa
On Wed, 8 Feb 2012 14:38:07 -0200 Marcelo Tosatti wrote: > Please don't forget the invalidate_page fix. I will send in a few days. Takuya -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http:

Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging

2012-02-08 Thread Marcelo Tosatti
On Sun, Feb 05, 2012 at 08:42:41PM +0900, Takuya Yoshikawa wrote: > From: Takuya Yoshikawa > > This patch fixes a race introduced by: > > commit 95d4c16ce78cb6b7549a09159c409d52ddd18dae > KVM: Optimize dirty logging by rmap_write_protect() > > During protecting pages for dirty logging, othe

Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging

2012-02-06 Thread Avi Kivity
On 02/06/2012 07:12 AM, Takuya Yoshikawa wrote: > (2012/02/06 14:02), Xiao Guangrong wrote: > >> I am worrying if other paths(such as like >> kvm_mmu_notifier_invalidate_page) >> which unmap/modify writeable ptes and flush TLBs out of mmu lock have >> the >> same problem? >> > > Yes, I think so ...

Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging

2012-02-05 Thread Takuya Yoshikawa
(2012/02/06 14:02), Xiao Guangrong wrote: I am worrying if other paths(such as like kvm_mmu_notifier_invalidate_page) which unmap/modify writeable ptes and flush TLBs out of mmu lock have the same problem? Yes, I think so ... (long standing bug?) Let's ask Avi if he prefers to fix it separat

Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging

2012-02-05 Thread Xiao Guangrong
On 02/06/2012 11:53 AM, Xiao Guangrong wrote: > On 02/06/2012 11:46 AM, Takuya Yoshikawa wrote: > >> (2012/02/06 12:40), Xiao Guangrong wrote: >>> On 02/05/2012 07:42 PM, Takuya Yoshikawa wrote: >>> From: Takuya Yoshikawa This patch fixes a race introduced by: commit 9

Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging

2012-02-05 Thread Xiao Guangrong
On 02/06/2012 11:46 AM, Takuya Yoshikawa wrote: > (2012/02/06 12:40), Xiao Guangrong wrote: >> On 02/05/2012 07:42 PM, Takuya Yoshikawa wrote: >> >>> From: Takuya Yoshikawa >>> >>> This patch fixes a race introduced by: >>> >>>commit 95d4c16ce78cb6b7549a09159c409d52ddd18dae >>>KVM: Optimiz

Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging

2012-02-05 Thread Takuya Yoshikawa
(2012/02/06 12:40), Xiao Guangrong wrote: On 02/05/2012 07:42 PM, Takuya Yoshikawa wrote: From: Takuya Yoshikawa This patch fixes a race introduced by: commit 95d4c16ce78cb6b7549a09159c409d52ddd18dae KVM: Optimize dirty logging by rmap_write_protect() During protecting pages for dirty

Re: [PATCH for 3.3] KVM: Fix write protection race during dirty logging

2012-02-05 Thread Xiao Guangrong
On 02/05/2012 07:42 PM, Takuya Yoshikawa wrote: > From: Takuya Yoshikawa > > This patch fixes a race introduced by: > > commit 95d4c16ce78cb6b7549a09159c409d52ddd18dae > KVM: Optimize dirty logging by rmap_write_protect() > > During protecting pages for dirty logging, other threads may als

[PATCH for 3.3] KVM: Fix write protection race during dirty logging

2012-02-05 Thread Takuya Yoshikawa
From: Takuya Yoshikawa This patch fixes a race introduced by: commit 95d4c16ce78cb6b7549a09159c409d52ddd18dae KVM: Optimize dirty logging by rmap_write_protect() During protecting pages for dirty logging, other threads may also try to protect a page in mmu_sync_children() or kvm_mmu_get_pag