Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-10-30 Thread Andrew Jones
On Fri, Sep 26, 2014 at 09:51:15AM +0200, Christoffer Dall wrote: On Tue, Sep 16, 2014 at 08:57:31AM -0400, Andrew Jones wrote: - Original Message - Il 16/09/2014 14:43, Andrew Jones ha scritto: I don't think we need to worry about this case. AFAIU, enabling the caches

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-26 Thread Christoffer Dall
On Tue, Sep 16, 2014 at 08:57:31AM -0400, Andrew Jones wrote: - Original Message - Il 16/09/2014 14:43, Andrew Jones ha scritto: I don't think we need to worry about this case. AFAIU, enabling the caches for a particular cpu shouldn't require any synchronization. So we

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-18 Thread Paolo Bonzini
Il 16/09/2014 04:06, Andrew Jones ha scritto: We shouldn't try Load-Exclusive instructions unless we've enabled memory management, as these instructions depend on the data cache unit's coherency monitor. This patch adds a new setup boolean, initialized to false, that is used to guard

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 04:06, Andrew Jones ha scritto: We shouldn't try Load-Exclusive instructions unless we've enabled memory management, as these instructions depend on the data cache unit's coherency monitor. This patch adds a new setup boolean, initialized to false, that is used to guard

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-16 Thread Andrew Jones
- Original Message - Il 16/09/2014 04:06, Andrew Jones ha scritto: We shouldn't try Load-Exclusive instructions unless we've enabled memory management, as these instructions depend on the data cache unit's coherency monitor. This patch adds a new setup boolean, initialized to

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 14:12, Andrew Jones ha scritto: Should it at least write 1 to the spinlock? I thought about that. So on one hand we might get a somewhat functional synchronization mechanism, which may be enough for some unit test that doesn't enable caches, but still needs it. On the other

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-16 Thread Andrew Jones
- Original Message - Il 16/09/2014 14:12, Andrew Jones ha scritto: Should it at least write 1 to the spinlock? I thought about that. So on one hand we might get a somewhat functional synchronization mechanism, which may be enough for some unit test that doesn't enable caches,

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 14:43, Andrew Jones ha scritto: I don't think we need to worry about this case. AFAIU, enabling the caches for a particular cpu shouldn't require any synchronization. So we should be able to do enable caches spin_lock start other processors spin_unlock Ok,

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-16 Thread Andrew Jones
- Original Message - - Original Message - Il 16/09/2014 14:12, Andrew Jones ha scritto: Should it at least write 1 to the spinlock? I thought about that. So on one hand we might get a somewhat functional synchronization mechanism, which may be enough for some

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-16 Thread Andrew Jones
- Original Message - Il 16/09/2014 14:43, Andrew Jones ha scritto: I don't think we need to worry about this case. AFAIU, enabling the caches for a particular cpu shouldn't require any synchronization. So we should be able to do enable caches spin_lock start

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-16 Thread Andrew Jones
- Original Message - Il 16/09/2014 14:43, Andrew Jones ha scritto: I don't think we need to worry about this case. AFAIU, enabling the caches for a particular cpu shouldn't require any synchronization. So we should be able to do enable caches spin_lock start

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-16 Thread Andrew Jones
- Original Message - - Original Message - Il 16/09/2014 14:43, Andrew Jones ha scritto: I don't think we need to worry about this case. AFAIU, enabling the caches for a particular cpu shouldn't require any synchronization. So we should be able to do

Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-16 Thread Andrew Jones
On Tue, Sep 16, 2014 at 10:38:11AM -0400, Andrew Jones wrote: - Original Message - - Original Message - Il 16/09/2014 14:43, Andrew Jones ha scritto: I don't think we need to worry about this case. AFAIU, enabling the caches for a particular cpu shouldn't

[PATCH kvm-unit-tests] arm: fix crash when caches are off

2014-09-15 Thread Andrew Jones
We shouldn't try Load-Exclusive instructions unless we've enabled memory management, as these instructions depend on the data cache unit's coherency monitor. This patch adds a new setup boolean, initialized to false, that is used to guard Load-Exclusive instructions. Eventually we'll add more