The IOAPIC spec says:
When accessing these registers, accesses must be done one dword at a time.
For example, software should never access byte 2 from the Data register before
accessing bytes 0 and 1. The hardware will not attempt to recover from a bad
programming model in this case.
So, this pat
On Fri, Jul 02, 2010 at 04:00:12PM +0800, Xiao Guangrong wrote:
> The IOAPIC spec says:
>
> When accessing these registers, accesses must be done one dword at a time.
> For example, software should never access byte 2 from the Data register before
> accessing bytes 0 and 1. The hardware will not a
Marcelo Tosatti wrote:
>> +if (len != 4) {
>> +printk(KERN_WARNING "ioapic: wrong length %d\n", len);
>> +return 0;
>> +}
>> +
>
> Just remove the printks please, as guests can flood hosts dmesg.
>
OK, please review this one, thanks, Marcelo!
Subject: [PATCH v
On 07/02/2010 11:00 AM, Xiao Guangrong wrote:
The IOAPIC spec says:
When accessing these registers, accesses must be done one dword at a time.
For example, software should never access byte 2 from the Data register before
accessing bytes 0 and 1. The hardware will not attempt to recover from a b
Avi Kivity wrote:
> On 07/02/2010 11:00 AM, Xiao Guangrong wrote:
>> The IOAPIC spec says:
>>
>> When accessing these registers, accesses must be done one dword at a
>> time.
>> For example, software should never access byte 2 from the Data
>> register before
>> accessing bytes 0 and 1. The hardw
On Mon, Jul 05, 2010 at 11:47:06AM +0800, Xiao Guangrong wrote:
> > There might be guests that use incorrect access despite the
> > documentation; if real hardware supports it, it should work. So we need
> > to start with just a warning, and allow the access. Later we can drop
> > the invalid acc
On 07/05/2010 06:47 AM, Xiao Guangrong wrote:
Avi Kivity wrote:
On 07/02/2010 11:00 AM, Xiao Guangrong wrote:
The IOAPIC spec says:
When accessing these registers, accesses must be done one dword at a
time.
For example, software should never access byte 2 from the Data
register befo
Avi Kivity wrote:
>
>>> There might be guests that use incorrect access despite the
>>> documentation; if real hardware supports it, it should work. So we need
>>> to start with just a warning, and allow the access. Later we can drop
>>> the invalid access.
>>>
>> If the OS contravene t
On 07/05/2010 10:56 AM, Xiao Guangrong wrote:
Well, there's the spec and there's real life, but in this case we can
try and if we see a problem we'll re-add the other access length.
OK, i'll do it as your suggestion, thanks.
I meant that you can drop access length != 4, same as in
