Re: [PATCH v2 1/2] KVM: SVM: Replace svm_has() by standard Linux cpuid accessors

2010-11-11 Thread Joerg Roedel
On Tue, Nov 09, 2010 at 04:15:42PM +0200, Avi Kivity wrote: - if (nr == BP_VECTOR !svm_has(SVM_FEATURE_NRIP)) { + if (nr == BP_VECTOR !static_cpu_has(X86_FEATURE_NRIPS)) { What is static_cpu_has and why you use it only here and boot_cpu_has in all other places? Joerg -- To

Re: [PATCH v2 1/2] KVM: SVM: Replace svm_has() by standard Linux cpuid accessors

2010-11-11 Thread Avi Kivity
On 11/11/2010 04:46 PM, Joerg Roedel wrote: On Tue, Nov 09, 2010 at 04:15:42PM +0200, Avi Kivity wrote: - if (nr == BP_VECTOR !svm_has(SVM_FEATURE_NRIP)) { + if (nr == BP_VECTOR !static_cpu_has(X86_FEATURE_NRIPS)) { What is static_cpu_has It's like boot_cpu_has, only it works by

Re: [PATCH v2 1/2] KVM: SVM: Replace svm_has() by standard Linux cpuid accessors

2010-11-11 Thread Joerg Roedel
On Thu, Nov 11, 2010 at 04:50:10PM +0200, Avi Kivity wrote: On 11/11/2010 04:46 PM, Joerg Roedel wrote: On Tue, Nov 09, 2010 at 04:15:42PM +0200, Avi Kivity wrote: - if (nr == BP_VECTOR !svm_has(SVM_FEATURE_NRIP)) { + if (nr == BP_VECTOR !static_cpu_has(X86_FEATURE_NRIPS)) { What is

[PATCH v2 1/2] KVM: SVM: Replace svm_has() by standard Linux cpuid accessors

2010-11-09 Thread Avi Kivity
Instead of querying cpuid directly, use the Linux accessors (boot_cpu_has, etc.). This allows the things like the clearcpuid kernel command line to work (when it's fixed wrt scattered cpuid bits). Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/svm.c | 15 +-- 1 files