Re: [PATCH v2 1/6] VMX: Add tests for CR3 and CR8 interception

2014-06-17 Thread Jan Kiszka
On 2014-06-17 09:41, Paolo Bonzini wrote: > Il 17/06/2014 09:04, Jan Kiszka ha scritto: >> >> -#define FIELD_EXIT_QUAL0 >> -#define FIELD_INSN_INFO1 >> +#define FIELD_EXIT_QUAL(1 << 1) >> +#define FIELD_INSN_INFO(1 << 2) > > Heh, you probably wanted 1<<0 and 1<<1.

Re: [PATCH v2 1/6] VMX: Add tests for CR3 and CR8 interception

2014-06-17 Thread Paolo Bonzini
Il 17/06/2014 09:04, Jan Kiszka ha scritto: -#define FIELD_EXIT_QUAL0 -#define FIELD_INSN_INFO1 +#define FIELD_EXIT_QUAL(1 << 1) +#define FIELD_INSN_INFO(1 << 2) Heh, you probably wanted 1<<0 and 1<<1. I'll fix it up. :) Paolo -

[PATCH v2 1/6] VMX: Add tests for CR3 and CR8 interception

2014-06-17 Thread Jan Kiszka
Need to fix FIELD_* constants for this to make the exit qualification check work. Signed-off-by: Jan Kiszka --- x86/vmx.h | 2 ++ x86/vmx_tests.c | 32 +--- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/x86/vmx.h b/x86/vmx.h index 26dd161..69a