Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-07 Thread Avi Kivity
On 02/03/2010 10:53 AM, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel before vmsave) - cpu_synchronize_all_post_init

Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-07 Thread Jan Kiszka
Avi Kivity wrote: On 02/03/2010 10:53 AM, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel before vmsave) -

Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-07 Thread Avi Kivity
On 02/07/2010 03:51 PM, Jan Kiszka wrote: Avi Kivity wrote: On 02/03/2010 10:53 AM, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete

Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-07 Thread Jan Kiszka
Avi Kivity wrote: On 02/07/2010 03:51 PM, Jan Kiszka wrote: Avi Kivity wrote: On 02/03/2010 10:53 AM, Jan Kiszka wrote: This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in

Re: [PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-07 Thread Avi Kivity
On 02/07/2010 04:26 PM, Jan Kiszka wrote: Well, to me it makes more sense to name them from the point of view of the vcpu that is doing the update. I'm open for a better name - except for sync as writebacks are always synchronous from the POV of the modified VCPU. I meant that the

[PATCH v2 14/21] qemu-kvm: Rework VCPU state writeback API

2010-02-03 Thread Jan Kiszka
This grand cleanup drops all reset and vmsave/load related synchronization points in favor of four(!) generic hooks: - cpu_synchronize_all_states in qemu_savevm_state_complete (initial sync from kernel before vmsave) - cpu_synchronize_all_post_init in qemu_loadvm_state (writeback after