Re: [PATCH v2 17/18] vhost: don't bother copying iovecs in handle_rx(), kill memcpy_toiovecend()

2015-02-03 Thread Michael S. Tsirkin
Hmm having second thoughts here. Will this modify the iov in vq-iov? If yes, how will recvmsg fill it? OK that was just me misunderstanding what the function does. As it doesn't modify the iovec itself, I think there's no issue, my ack stands. -- To unsubscribe from this list: send the line

Re: [PATCH v2 17/18] vhost: don't bother copying iovecs in handle_rx(), kill memcpy_toiovecend()

2015-02-03 Thread Al Viro
On Tue, Feb 03, 2015 at 04:21:54PM +0100, Michael S. Tsirkin wrote: Hmm having second thoughts here. Will this modify the iov in vq-iov? If yes, how will recvmsg fill it? OK that was just me misunderstanding what the function does. As it doesn't modify the iovec itself, I think there's

Re: [PATCH v2 17/18] vhost: don't bother copying iovecs in handle_rx(), kill memcpy_toiovecend()

2015-02-03 Thread Michael S. Tsirkin
On Mon, Feb 02, 2015 at 07:59:36AM +, Al Viro wrote: From: Al Viro v...@zeniv.linux.org.uk Cc: Michael S. Tsirkin m...@redhat.com Cc: kvm@vger.kernel.org Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- So this made me notice a bug in vhost introduced in 3.19. I sent a patch for

Re: [PATCH v2 17/18] vhost: don't bother copying iovecs in handle_rx(), kill memcpy_toiovecend()

2015-02-03 Thread Michael S. Tsirkin
On Mon, Feb 02, 2015 at 07:59:36AM +, Al Viro wrote: From: Al Viro v...@zeniv.linux.org.uk Cc: Michael S. Tsirkin m...@redhat.com Cc: kvm@vger.kernel.org Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- drivers/vhost/net.c | 79 ++---

[PATCH v2 17/18] vhost: don't bother copying iovecs in handle_rx(), kill memcpy_toiovecend()

2015-02-02 Thread Al Viro
From: Al Viro v...@zeniv.linux.org.uk Cc: Michael S. Tsirkin m...@redhat.com Cc: kvm@vger.kernel.org Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- drivers/vhost/net.c | 79 ++--- include/linux/uio.h | 3 -- lib/iovec.c | 26