Re: [PATCH v2 3/6] kvm: Sanitize KVM_IRQFD flags

2012-06-28 Thread Avi Kivity
On 06/27/2012 12:21 PM, Michael S. Tsirkin wrote: > On Tue, Jun 26, 2012 at 11:09:32PM -0600, Alex Williamson wrote: >> We only know of one so far. >> >> Signed-off-by: Alex Williamson > > Ugh. So we have a bug: we should have sanitized the fields. > If there's buggy userspace that only set the

Re: [PATCH v2 3/6] kvm: Sanitize KVM_IRQFD flags

2012-06-27 Thread Michael S. Tsirkin
On Wed, Jun 27, 2012 at 02:12:18PM -0600, Alex Williamson wrote: > On Wed, 2012-06-27 at 12:21 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 26, 2012 at 11:09:32PM -0600, Alex Williamson wrote: > > > We only know of one so far. > > > > > > Signed-off-by: Alex Williamson > > > > Ugh. So we hav

Re: [PATCH v2 3/6] kvm: Sanitize KVM_IRQFD flags

2012-06-27 Thread Alex Williamson
On Wed, 2012-06-27 at 12:21 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 26, 2012 at 11:09:32PM -0600, Alex Williamson wrote: > > We only know of one so far. > > > > Signed-off-by: Alex Williamson > > Ugh. So we have a bug: we should have sanitized the fields. > If there's buggy userspace that

Re: [PATCH v2 3/6] kvm: Sanitize KVM_IRQFD flags

2012-06-27 Thread Michael S. Tsirkin
On Tue, Jun 26, 2012 at 11:09:32PM -0600, Alex Williamson wrote: > We only know of one so far. > > Signed-off-by: Alex Williamson Ugh. So we have a bug: we should have sanitized the fields. If there's buggy userspace that only set the low bit it will break with this change. Is it too late now? D

[PATCH v2 3/6] kvm: Sanitize KVM_IRQFD flags

2012-06-26 Thread Alex Williamson
We only know of one so far. Signed-off-by: Alex Williamson --- virt/kvm/eventfd.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/virt/kvm/eventfd.c b/virt/kvm/eventfd.c index c307c24..7d7e2aa 100644 --- a/virt/kvm/eventfd.c +++ b/virt/kvm/eventfd.c @@ -340,6 +340,9 @@ kvm_irqfd_deass