Re: [PATCH v3] PCI: Add guard to avoid mapping a invalid msix base address

2015-02-03 Thread Jan Beulich
>>> On 02.02.15 at 22:06, wrote: > I applied this to pci/msi for v3.20, thanks! I reworked the changelog as > follows; let me know if it still doesn't make things clear: Thanks, looks good to me now. Jan -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message

Re: [PATCH v3] PCI: Add guard to avoid mapping a invalid msix base address

2015-02-02 Thread Yijing Wang
> I applied this to pci/msi for v3.20, thanks! I reworked the changelog as > follows; let me know if it still doesn't make things clear: > It's more clear, thanks for your improvement very much! Thanks! Yijing. > > commit 6a878e5085fe97bd1e222b7883a1b815fcbbe4ed > Author: Yijing Wang > Date:

Re: [PATCH v3] PCI: Add guard to avoid mapping a invalid msix base address

2015-02-02 Thread Bjorn Helgaas
[+cc Jan] On Thu, Jan 29, 2015 at 11:54:43AM +0800, Yijing Wang wrote: > Sometimes, a pci bridge device BAR was not assigned > properly. After we call pci_bus_assign_resources(), the > resource of the BAR would be reseted. So if we try to > enable msix for this device, it will map a invalid > reso

Re: [Xen-devel] [PATCH v3] PCI: Add guard to avoid mapping a invalid msix base address

2015-01-29 Thread Yijing Wang
On 2015/1/29 22:12, Bjorn Helgaas wrote: > On Thu, Jan 29, 2015 at 7:15 AM, Jan Beulich wrote: > On 29.01.15 at 04:54, wrote: >>> --- a/drivers/pci/msi.c >>> +++ b/drivers/pci/msi.c >>> @@ -694,11 +694,16 @@ static void __iomem *msix_map_region(struct pci_dev >>> *dev, unsigned nr_entries) >

Re: [Xen-devel] [PATCH v3] PCI: Add guard to avoid mapping a invalid msix base address

2015-01-29 Thread Bjorn Helgaas
On Thu, Jan 29, 2015 at 7:15 AM, Jan Beulich wrote: On 29.01.15 at 04:54, wrote: >> --- a/drivers/pci/msi.c >> +++ b/drivers/pci/msi.c >> @@ -694,11 +694,16 @@ static void __iomem *msix_map_region(struct pci_dev >> *dev, unsigned nr_entries) >> { >> resource_size_t phys_addr; >>

Re: [Xen-devel] [PATCH v3] PCI: Add guard to avoid mapping a invalid msix base address

2015-01-29 Thread Jan Beulich
>>> On 29.01.15 at 04:54, wrote: > --- a/drivers/pci/msi.c > +++ b/drivers/pci/msi.c > @@ -694,11 +694,16 @@ static void __iomem *msix_map_region(struct pci_dev > *dev, unsigned nr_entries) > { > resource_size_t phys_addr; > u32 table_offset; > + unsigned long flags; > u8 b

[PATCH v3] PCI: Add guard to avoid mapping a invalid msix base address

2015-01-28 Thread Yijing Wang
Sometimes, a pci bridge device BAR was not assigned properly. After we call pci_bus_assign_resources(), the resource of the BAR would be reseted. So if we try to enable msix for this device, it will map a invalid resource as the msix base address, and a warning call trace will report. pci_bus_assi