Re: [PATCH v3 05/11] KVM: MMU: do not mark accessed bit on pte write path

2011-09-15 Thread Marcelo Tosatti
On Wed, Sep 14, 2011 at 12:55:09PM +0300, Avi Kivity wrote: > On 09/13/2011 09:29 PM, Xiao Guangrong wrote: > >On 09/13/2011 06:53 PM, Avi Kivity wrote: > >> On 08/30/2011 05:35 AM, Xiao Guangrong wrote: > >>> In current code, the accessed bit is always set when page fault occurred, > >>> do not

Re: [PATCH v3 05/11] KVM: MMU: do not mark accessed bit on pte write path

2011-09-14 Thread Avi Kivity
On 09/13/2011 09:29 PM, Xiao Guangrong wrote: On 09/13/2011 06:53 PM, Avi Kivity wrote: > On 08/30/2011 05:35 AM, Xiao Guangrong wrote: >> In current code, the accessed bit is always set when page fault occurred, >> do not need to set it on pte write path > > What about speculative sptes that

Re: [PATCH v3 05/11] KVM: MMU: do not mark accessed bit on pte write path

2011-09-13 Thread Xiao Guangrong
On 09/13/2011 06:53 PM, Avi Kivity wrote: > On 08/30/2011 05:35 AM, Xiao Guangrong wrote: >> In current code, the accessed bit is always set when page fault occurred, >> do not need to set it on pte write path > > What about speculative sptes that are then only accessed via emulation? > The gfn

Re: [PATCH v3 05/11] KVM: MMU: do not mark accessed bit on pte write path

2011-09-13 Thread Avi Kivity
On 08/30/2011 05:35 AM, Xiao Guangrong wrote: In current code, the accessed bit is always set when page fault occurred, do not need to set it on pte write path What about speculative sptes that are then only accessed via emulation? -- error compiling committee.c: too many arguments to function

[PATCH v3 05/11] KVM: MMU: do not mark accessed bit on pte write path

2011-08-29 Thread Xiao Guangrong
In current code, the accessed bit is always set when page fault occurred, do not need to set it on pte write path Signed-off-by: Xiao Guangrong --- arch/x86/include/asm/kvm_host.h |1 - arch/x86/kvm/mmu.c | 22 +- 2 files changed, 1 insertions(+), 22 deleti