Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-07 Thread Marc Zyngier
On 07/08/15 08:05, Eric Auger wrote: > Hi Marc, > On 08/06/2015 06:44 PM, Marc Zyngier wrote: >> On 05/08/15 14:47, Christoffer Dall wrote: >>> On Wed, Aug 05, 2015 at 01:47:27PM +0200, Eric Auger wrote: On 08/05/2015 12:53 PM, Christoffer Dall wrote: > On Wed, Aug 05, 2015 at 10:44:09AM +

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-07 Thread Eric Auger
Hi Marc, On 08/06/2015 06:44 PM, Marc Zyngier wrote: > On 05/08/15 14:47, Christoffer Dall wrote: >> On Wed, Aug 05, 2015 at 01:47:27PM +0200, Eric Auger wrote: >>> On 08/05/2015 12:53 PM, Christoffer Dall wrote: On Wed, Aug 05, 2015 at 10:44:09AM +0100, Marc Zyngier wrote: > On 05/08/15 0

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-06 Thread Marc Zyngier
On 05/08/15 14:47, Christoffer Dall wrote: > On Wed, Aug 05, 2015 at 01:47:27PM +0200, Eric Auger wrote: >> On 08/05/2015 12:53 PM, Christoffer Dall wrote: >>> On Wed, Aug 05, 2015 at 10:44:09AM +0100, Marc Zyngier wrote: On 05/08/15 08:32, Eric Auger wrote: > Hi Marc, > On 08/04/2015

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-05 Thread Christoffer Dall
On Wed, Aug 05, 2015 at 01:47:27PM +0200, Eric Auger wrote: > On 08/05/2015 12:53 PM, Christoffer Dall wrote: > > On Wed, Aug 05, 2015 at 10:44:09AM +0100, Marc Zyngier wrote: > >> On 05/08/15 08:32, Eric Auger wrote: > >>> Hi Marc, > >>> On 08/04/2015 06:44 PM, Marc Zyngier wrote: > On 04/08/

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-05 Thread Eric Auger
On 08/05/2015 12:53 PM, Christoffer Dall wrote: > On Wed, Aug 05, 2015 at 10:44:09AM +0100, Marc Zyngier wrote: >> On 05/08/15 08:32, Eric Auger wrote: >>> Hi Marc, >>> On 08/04/2015 06:44 PM, Marc Zyngier wrote: On 04/08/15 17:21, Eric Auger wrote: > Hi Marc, > On 07/24/2015 05:55 PM,

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-05 Thread Christoffer Dall
On Wed, Aug 05, 2015 at 10:44:09AM +0100, Marc Zyngier wrote: > On 05/08/15 08:32, Eric Auger wrote: > > Hi Marc, > > On 08/04/2015 06:44 PM, Marc Zyngier wrote: > >> On 04/08/15 17:21, Eric Auger wrote: > >>> Hi Marc, > >>> On 07/24/2015 05:55 PM, Marc Zyngier wrote: > Virtual interrupts mapp

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-05 Thread Marc Zyngier
On 05/08/15 08:32, Eric Auger wrote: > Hi Marc, > On 08/04/2015 06:44 PM, Marc Zyngier wrote: >> On 04/08/15 17:21, Eric Auger wrote: >>> Hi Marc, >>> On 07/24/2015 05:55 PM, Marc Zyngier wrote: Virtual interrupts mapped to a HW interrupt should only be triggered from inside the kernel. O

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-05 Thread Eric Auger
Hi Marc, On 08/04/2015 06:44 PM, Marc Zyngier wrote: > On 04/08/15 17:21, Eric Auger wrote: >> Hi Marc, >> On 07/24/2015 05:55 PM, Marc Zyngier wrote: >>> Virtual interrupts mapped to a HW interrupt should only be triggered >>> from inside the kernel. Otherwise, you could end up confusing the >>> k

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-04 Thread Christoffer Dall
On Tue, Aug 04, 2015 at 05:02:41PM +0100, Marc Zyngier wrote: > On 04/08/15 14:45, Christoffer Dall wrote: > > On Fri, Jul 24, 2015 at 04:55:07PM +0100, Marc Zyngier wrote: > >> Virtual interrupts mapped to a HW interrupt should only be triggered > >> from inside the kernel. Otherwise, you could en

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-04 Thread Marc Zyngier
On 04/08/15 17:21, Eric Auger wrote: > Hi Marc, > On 07/24/2015 05:55 PM, Marc Zyngier wrote: >> Virtual interrupts mapped to a HW interrupt should only be triggered >> from inside the kernel. Otherwise, you could end up confusing the >> kernel (and the GIC's) state machine. >> >> Rearrange the inj

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-04 Thread Eric Auger
Hi Marc, On 07/24/2015 05:55 PM, Marc Zyngier wrote: > Virtual interrupts mapped to a HW interrupt should only be triggered > from inside the kernel. Otherwise, you could end up confusing the > kernel (and the GIC's) state machine. > > Rearrange the injection path so that kvm_vgic_inject_irq is >

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-04 Thread Marc Zyngier
On 04/08/15 14:45, Christoffer Dall wrote: > On Fri, Jul 24, 2015 at 04:55:07PM +0100, Marc Zyngier wrote: >> Virtual interrupts mapped to a HW interrupt should only be triggered >> from inside the kernel. Otherwise, you could end up confusing the >> kernel (and the GIC's) state machine. >> >> Rear

Re: [PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-08-04 Thread Christoffer Dall
On Fri, Jul 24, 2015 at 04:55:07PM +0100, Marc Zyngier wrote: > Virtual interrupts mapped to a HW interrupt should only be triggered > from inside the kernel. Otherwise, you could end up confusing the > kernel (and the GIC's) state machine. > > Rearrange the injection path so that kvm_vgic_inject_

[PATCH v3 09/11] KVM: arm/arm64: vgic: Prevent userspace injection of a mapped interrupt

2015-07-24 Thread Marc Zyngier
Virtual interrupts mapped to a HW interrupt should only be triggered from inside the kernel. Otherwise, you could end up confusing the kernel (and the GIC's) state machine. Rearrange the injection path so that kvm_vgic_inject_irq is used for non-mapped interrupts, and kvm_vgic_inject_mapped_irq is